Attachment 846874 Details for Bug 1049042 – my patch

[patch] my patch

fedora-review-unpack.patch (text/plain), 1.19 KB, created by Orion Poplawski on 2014-01-07 23:55:45 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Orion Poplawski

Created: 2014-01-07 23:55:45 UTC

Size: 1.19 KB

patch

obsolete

>diff -up fedora-review-0.5.1/src/FedoraReview/deps.py.unpack fedora-review-0.5.1/src/FedoraReview/deps.py
>--- fedora-review-0.5.1/src/FedoraReview/deps.py.unpack	2013-12-13 04:40:59.000000000 -0700
>+++ fedora-review-0.5.1/src/FedoraReview/deps.py	2014-01-07 16:54:49.890273800 -0700
>@@ -99,7 +99,11 @@ def list_dirs(pkg_filename):
>             line = rpm.stdout.next().strip()
>         except StopIteration:
>             return dirs
>-        path, mode = line.rsplit(None, 10)[0:5:4]
>+        try:
>+            path, mode = line.rsplit(None, 10)[0:5:4]
>+        except ValueError:
>+            # E. g., when given '(contains no files)'
>+            continue
>         mode = int(mode, 8)
>         if mode & 040000:
>             dirs.append(path)
>@@ -180,7 +184,11 @@ def listpaths(pkg_filename):
>             line = rpm.stdout.next().strip()
>         except StopIteration:
>             return dirs, files
>-        path, mode = line.rsplit(None, 10)[0:5:4]
>+        try:
>+            path, mode = line.rsplit(None, 10)[0:5:4]
>+        except ValueError:
>+            # E. g., when given '(contains no files)'
>+            continue
>         mode = int(mode, 8)
>         if mode & 040000:
>             dirs.append(path)

Actions: View | Diff

Attachments on bug 1049042: 846874