Attachment 848113 Details for Bug 550725 – Patch backported from mutt-1.5.22 by Jakub Cajka

[patch] Patch backported from mutt-1.5.22 by Jakub Cajka

Fedora-550725-ID409795.patch (text/plain), 1.63 KB, created by Honza Horak on 2014-01-10 09:33:41 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Honza Horak

Created: 2014-01-10 09:33:41 UTC

Size: 1.63 KB

patch

obsolete

>Patch to fix bug https://bugzilla.redhat.com/show_bug.cgi?id=550725
>Author: Jakub Cajka
>
>	Attachment viewed using the autoview function is converted to utf-8. This behaviour causes problems with attachments containing informations about its encoding(xml, html,...).
>
>	Setup:
>	
>		Clean installation of mutt.(version 1.5.21-20.fc19 used, this bug should also affect earlier versions)
>		An email with attachment of non utf-8 encoded html(xml) in mailbox(Use for example email from redhat bugzilla https://bugzilla.redhat.com/attachment.cgi?id=380487)
>	
>	Steps to reproduce:
>
>		Run mutt.
>		Change to your mailbox('c' default key).
>		Select the email with attachment of non utf-8 encoded html(xml).
>		Open email attachments view('v' by default).
>		Select non utf-8 html(xml) attachment.
>		Press 'm'(default key). 
>		Default web browser should appear showing a malformed document(manually setting encoding in browser to utf-8 should make the document look right.).
>
>relevant upstream links:
>	upstream patch http://dev.mutt.org/trac/changeset/7fcc0049f250
>	bug tikets: http://dev.mutt.org/trac/ticket/3293
>				http://dev.mutt.org/trac/ticket/3234
>
>
>--- mutt-1.5.21/attach.c	2010-04-05 20:47:13.000000000 +0200
>+++ attach.c	2013-12-25 15:49:48.234662689 +0100
>@@ -802,8 +802,10 @@
>       STATE s;
> 
>       memset (&s, 0, sizeof (s));
>-      s.flags |= M_CHARCONV;
>-
>+      /*
>+       * following flag set is redundant, because it corrupts outputted file if file contains encoding information about itself ie. xml, html etc.
>+       * s.flags |= M_CHARCONV;
>+       */ 
>       if ((s.fpout = mutt_save_attachment_open (path, flags)) == NULL)
>       {
> 	mutt_perror ("fopen");

Actions: View | Diff

Attachments on bug 550725: 380487 | 380489 | 380491 | 381898 | 848113