Attachment 850461 Details for Bug 1051753 – fedora-review.txt

fedora-review.txt

review.txt (text/plain), 6.71 KB, created by Shawn Iwinski on 2014-01-15 12:34:58 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Shawn Iwinski

Created: 2014-01-15 12:34:58 UTC

Size: 6.71 KB

patch

obsolete

>Package Review
>==============
>
>Legend:
>[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
>[ ] = Manual review needed
>
>
>
>===== MUST items =====
>
>Generic:
>[x]: Package is licensed with an open-source compatible license and meets
>     other legal requirements as defined in the legal section of Packaging
>     Guidelines.
>[x]: License field in the package spec file matches the actual license.
>     Note: Checking patched sources after %prep for licenses. Licenses found:
>     "Unknown or generated". 55 files have unknown license.
>[x]: Package contains no bundled libraries without FPC exception.
>[x]: Changelog in prescribed format.
>[x]: Sources contain only permissible code or content.
>[x]: Each %files section contains %defattr if rpm < 4.4
>[-]: Package contains desktop file if it is a GUI application.
>[-]: Development files must be in a -devel package
>[x]: Package uses nothing in %doc for runtime.
>[x]: Package consistently uses macros (instead of hard-coded directory names).
>
>     Since you define the "prerelease" global, instead of
>         0.1.beta1%{?dist}
>     should use
>         0.1.%{prerelease}%{?dist}
>
>[x]: Package is named according to the Package Naming Guidelines.
>[x]: Package does not generate any conflict.
>[x]: Package obeys FHS, except libexecdir and /usr/target.
>[-]: If the package is a rename of another package, proper Obsoletes and
>     Provides are present.
>[!]: Requires correct, justified where necessary.
>
>     Instead of
>         Requires:      php >= 5.3
>     need to use
>         Requires:      php-common >= 5.3
>     (see https://fedoraproject.org/wiki/Packaging:PHP#Requiring_a_Minimum_PHP_version)
>     (side note: if not packaging for EPEL5 "php(language)" would be used)
>
>     According to phpcompatinfo (version 2.26.0), need to add the following:
>         # phpcompatinfo (computed from version 4.0-beta1)
>         Requires:      php-date
>         Requires:      php-mbstring
>         Requires:      php-pcre
>         Requires:      php-pecl(zip)
>         Requires:      php-pdo
>         Requires:      php-session
>     (see https://fedoraproject.org/wiki/Packaging:PHP#Extensions_Requires)
>
>[x]: Spec file is legible and written in American English.
>[-]: Package contains systemd file(s) if in need.
>[x]: Package is not known to require an ExcludeArch tag.
>[x]: Large documentation must go in a -doc subpackage. Large could be size
>     (~1MB) or number of files.
>     Note: Documentation size is 40960 bytes in 5 files.
>[x]: Package complies to the Packaging Guidelines
>[x]: Package successfully compiles and builds into binary rpms on at least one
>     supported primary architecture.
>[x]: Package installs properly.
>[x]: Rpmlint is run on all rpms the build produces.
>     Note: No rpmlint messages.
>[x]: If (and only if) the source package includes the text of the license(s)
>     in its own file, then that file, containing the text of the license(s)
>     for the package is included in %doc.
>[x]: Package requires other packages for directories it uses.
>[x]: Package must own all directories that it creates.
>[x]: Package does not own files or directories owned by other packages.
>[x]: All build dependencies are listed in BuildRequires, except for any that
>     are listed in the exceptions section of Packaging Guidelines.
>[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
>[x]: EPEL5: Package does run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
>     beginning of %install.
>[x]: Macros in Summary, %description expandable at SRPM build time.
>[x]: Package does not contain duplicates in %files.
>[x]: Permissions on files are set properly.
>[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
>     work.
>[x]: Package is named using only allowed ASCII characters.
>[x]: Package do not use a name that already exist
>[x]: Package is not relocatable.
>[x]: Sources used to build the package match the upstream source, as provided
>     in the spec URL.
>[x]: Spec file name must match the spec package %{name}, in the format
>     %{name}.spec.
>[x]: File names are valid UTF-8.
>[x]: Packages must not store files under /srv, /opt or /usr/local
>[x]: EPEL5 requires explicit %clean with rm -rf %{buildroot} (or
>     $RPM_BUILD_ROOT)
>
>===== SHOULD items =====
>
>Generic:
>[-]: If the source package does not include license text(s) as a separate file
>     from upstream, the packager SHOULD query upstream to include it.
>[x]: Final provides and requires are sane (see attachments).
>[x]: Package functions as described.
>[x]: Latest version is packaged.
>[x]: Package does not include license text files separate from upstream.
>[-]: Description and summary sections in the package spec file contains
>     translations for supported Non-English languages, if available.
>[x]: Package should compile and build into binary rpms on all supported
>     architectures.
>[-]: %check is present and all tests pass.
>[x]: Packages should try to preserve timestamps of original installed files.
>[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
>[x]: Sources can be downloaded from URI in Source: tag
>[x]: Reviewer should test that the package builds in mock.
>[x]: Buildroot is not present
>[x]: Dist tag is present (not strictly required in GL).
>[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
>[x]: SourceX is a working URL.
>[x]: Spec use %global instead of %define unless justified.
>
>===== EXTRA items =====
>
>Generic:
>[x]: Rpmlint is run on all installed packages.
>     Note: No rpmlint messages.
>[x]: Spec file according to URL is the same as in SRPM.
>
>PHP:
>[x]: Run phpci static analyze on all php files.
>
>
>Rpmlint
>-------
>Checking: drupal7-webform-4.0-0.1.beta1.fc21.noarch.rpm
>          drupal7-webform-4.0-0.1.beta1.fc21.src.rpm
>2 packages and 0 specfiles checked; 0 errors, 0 warnings.
>
>
>
>
>Rpmlint (installed packages)
>----------------------------
># rpmlint drupal7-webform
>1 packages and 0 specfiles checked; 0 errors, 0 warnings.
># echo 'rpmlint-done:'
>
>
>
>Requires
>--------
>drupal7-webform (rpmlib, GLIBC filtered):
>    drupal7(core)
>    drupal7-ctools
>    drupal7-views
>    php
>
>
>
>Provides
>--------
>drupal7-webform:
>    drupal7(webform)
>    drupal7-webform
>
>
>
>Source checksums
>----------------
>http://ftp.drupal.org/files/projects/webform-7.x-4.0-beta1.tar.gz :
>  CHECKSUM(SHA256) this package     : ccce43f7d071e02f454de44928ee1e7c165d6c7182a3934935c826ab800e0520
>  CHECKSUM(SHA256) upstream package : ccce43f7d071e02f454de44928ee1e7c165d6c7182a3934935c826ab800e0520
>
>
>Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13
>Command line :/usr/bin/fedora-review --mock-config fedora-rawhide-x86_64 --define EPEL5 -b 1051753
>Buildroot used: fedora-rawhide-x86_64
>Active plugins: Generic, Shell-api
>Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby
>Disabled flags: EXARCH, BATCH, DISTTAG

Actions: View

Attachments on bug 1051753: 850460 | 850461 | 850462