Attachment 851226 Details for Bug 1054386 – additional patch improving process management for glxgears and reporting build host errors as failures

[patch] additional patch improving process management for glxgears and reporting build host errors as failures

0003-1054386-video-test-traceback-when-no-display-is-conn.patch (text/plain), 2.05 KB, created by Greg Nichols on 2014-01-16 18:51:32 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Greg Nichols

Created: 2014-01-16 18:51:32 UTC

Size: 2.05 KB

patch

obsolete

>From 786d506816f2c16891f5da824ce19f398cf713dc Mon Sep 17 00:00:00 2001
>From: Greg Nichols <gnichols@redhat.com>
>Date: Thu, 16 Jan 2014 13:49:30 -0500
>Subject: [PATCH 3/3] 1054386 - video test traceback when no display is
> connected
>
>---
> tests/video/video.py | 15 +++++++++++----
> 1 file changed, 11 insertions(+), 4 deletions(-)
>
>diff --git a/tests/video/video.py b/tests/video/video.py
>index 7f4cfef..6a7b83c 100644
>--- a/tests/video/video.py
>+++ b/tests/video/video.py
>@@ -148,7 +148,8 @@ class VideoTest(Test):
> 
>                  try:
>                      Command("rpm -Vf %s" % xmoduleFile).run()
>-                     self.checkXModuleVendorAndBuildHost(xmoduleFile)
>+                     if not self.checkXModuleVendorAndBuildHost(xmoduleFile):
>+                         success = False
>                  except Exception, e:
>                      print "Error: RPM verification failed for X module %s" % xmoduleFile
>                      print e
>@@ -235,7 +236,7 @@ class VideoTest(Test):
>         try:
>             print "Running: " + startxCommand
>             self.xServer = Command(startxCommand)
>-            self.xServer.run()
>+            self.xServer.start()
>             print "process %s" % self.xServer.getPID()
>         except HwCertCommandException, e:
>             print "Error: %s failed" % startxCommand
>@@ -246,12 +247,18 @@ class VideoTest(Test):
>         return True
> 
>     def runGLXGears(self):
>-        glxGears = Command("glxgears -display :2")
>+        glxGears = Command("glxgears -display :%s" % self.display)
>         print glxGears.command
>         try:
>-            glxGears.run()
>+            glxGears.start()
>             lines = 0
>             while lines < 5:
>+                returnCode = glxGears.poll()
>+                if returnCode:
>+                    print "Error: glxgears failed, return code: %s" % returnCode
>+                    glxGears.printOutput()
>+                    glxGears.printErrors()
>+                    return False
>                 line = glxGears.readline()
>                 if line:
>                     print line
>-- 
>1.8.4.2
>

Actions: View | Diff

Attachments on bug 1054386: 851215 | 851226