Attachment 851412 Details for Bug 1054626 – A patch that can fix the problem in my case

[patch] A patch that can fix the problem in my case

lftp_FileSet.patch (text/plain), 1.03 KB, created by John Lau on 2014-01-17 06:44:42 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: John Lau

Created: 2014-01-17 06:44:42 UTC

Size: 1.03 KB

patch

obsolete

>--- lftp-4.0.9/src/FileSet.cc	2009-10-09 15:46:57.000000000 +0100
>+++ lftp-4.0.9-patched/src/FileSet.cc	2014-01-16 09:29:06.095490839 +0000
>@@ -926,20 +926,20 @@
>    int mode1=(defined&MODE?mode:
>       (filetype_c=='d'?0755:(filetype_c=='l'?0777:0644)));
> 
>-   char usergroup[33];
>-   usergroup[0]=0;
>-   if(defined&(USER|GROUP))
>-      sprintf(usergroup,"%.16s%s%.16s",defined&USER?user:"?",
>-		  defined&GROUP?"/":"",defined&GROUP?group:"");
>+   const char *usergroup="";
>+   if(defined&(USER|GROUP)) {
>+       usergroup=xstring::format("%.16s%s%.16s",defined&USER?user:"?",
>+                   defined&GROUP?"/":"",defined&GROUP?group:"");
>+   }
> 
>    int w=20-strlen(usergroup);
>    if(w<1)
>       w=1;
>-   char size_str[20];
>+   char size_str[21];
>    if(defined&SIZE)
>-      sprintf(size_str,"%*lld",w,(long long)size);
>+      snprintf(size_str,sizeof(size_str),"%*lld",w,(long long)size);
>    else
>-      sprintf(size_str,"%*s",w,"-");
>+      snprintf(size_str,sizeof(size_str),"%*s",w,"-");
> 
>    const char *date_str="-";
>    if(defined&DATE)

Actions: View | Diff

Attachments on bug 1054626: 851412