Attachment 854371 Details for Bug 1057096 – Fix caller to match callee prototype

[patch] Fix caller to match callee prototype

0001-Fix-regression-in-libvirt.virStream.send.patch (text/plain), 1.17 KB, created by Robie Basak on 2014-01-23 12:58:11 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Robie Basak

Created: 2014-01-23 12:58:11 UTC

Size: 1.17 KB

patch

obsolete

>From 9501a8a65f0c7333a1cc5aac0a6d0f392ab3e7bc Mon Sep 17 00:00:00 2001
>From: Robie Basak <robie.basak@canonical.com>
>Date: Thu, 23 Jan 2014 12:26:25 +0000
>Subject: [PATCH] Fix regression in libvirt.virStream.send()
>
>Use the new 'O' convention to send a byte array, instead of the previous
>'z#i' convention which now fails. This fixes a regression caused by commit
>d40861.
>
>Commit d40861 changed the prototype of libvirtmod.virStreamSend, but did
>not change this caller. This completely broke libvirt.virStream.send
>(and thus also libvirt.virStream.sendAll) which still used the old
>convention.
>---
> libvirt-override-virStream.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/libvirt-override-virStream.py b/libvirt-override-virStream.py
>index cd44314..ce82da6 100644
>--- a/libvirt-override-virStream.py
>+++ b/libvirt-override-virStream.py
>@@ -122,6 +122,6 @@
>         with the call, but may instead be delayed until a
>         subsequent call.
>         """
>-        ret = libvirtmod.virStreamSend(self._o, data, len(data))
>+        ret = libvirtmod.virStreamSend(self._o, data)
>         if ret == -1: raise libvirtError ('virStreamSend() failed')
>         return ret
>-- 
>1.8.5.2
>

Actions: View | Diff

Attachments on bug 1057096: 854371