Attachment 857776 Details for Bug 1060050 – proposed patch

proposed patch

0001-flush-output-on-task-create-watch.patch (text/plain), 1.75 KB, created by Jan Stancek on 2014-01-31 09:56:37 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jan Stancek

Created: 2014-01-31 09:56:37 UTC

Size: 1.75 KB

patch

obsolete

>From 3364d5e5aeba3eee5584b822b39e41bf84aaab7d Mon Sep 17 00:00:00 2001
>Message-Id: <3364d5e5aeba3eee5584b822b39e41bf84aaab7d.1391161442.git.jstancek@redhat.com>
>From: Jan Stancek <jstancek@redhat.com>
>Date: Fri, 31 Jan 2014 10:29:47 +0100
>Subject: [PATCH] flush output on task create/watch
>
>Redirecting output from cli/koji to file or pipe makes output bufferred
>and information like created task and build progress is written to
>file/pipe only after task already completes:
>
>    # koji build --scratch eso-rhel-6 a.src.rpm | tee -a output.txt
>    Uploading srpm: a.src.rpm
>    [====================================] 100% 00:00:01 605.40 KiB 333.28 KiB/sec
>
><output stops here until build completes>
>
>    Created task: 123456
>    Task info: http://...?taskID=123456
>    Watching tasks (this may be safely interrupted)...
>
>Flush the stdout output, so that this information is available
>immediately.
>
>Signed-off-by: Jan Stancek <jstancek@redhat.com>
>---
> cli/koji |    2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
>diff --git a/cli/koji b/cli/koji
>index 089308c..84685f3 100755
>--- a/cli/koji
>+++ b/cli/koji
>@@ -428,6 +428,7 @@ def display_task_results(tasks):
>         else:
>             # shouldn't happen
>             print '%s has not completed' % task_label
>+    sys.stdout.flush()
> 
> def watch_tasks(session,tasklist,quiet=False):
>     global options
>@@ -933,6 +934,7 @@ def handle_build(options, session, args):
>     if not build_opts.quiet:
>         print "Created task:", task_id
>         print "Task info: %s/taskinfo?taskID=%s" % (options.weburl, task_id)
>+        sys.stdout.flush()
>     if build_opts.wait or (build_opts.wait is None and not _running_in_bg()):
>         session.logout()
>         return watch_tasks(session, [task_id], quiet=build_opts.quiet)
>-- 
>1.7.1
>

Actions: View

Attachments on bug 1060050: 857776