Attachment 857954 Details for Bug 1060319 – patch to fix inability of use "windows credentials" to login

[patch] patch to fix inability of use "windows credentials" to login

freeradius-mschap-autologon.patch (text/plain), 2.30 KB, created by Michal Bruncko on 2014-01-31 19:02:19 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Michal Bruncko

Created: 2014-01-31 19:02:19 UTC

Size: 2.30 KB

patch

obsolete

>diff -ru freeradius-server-2.1.12-old/src/modules/rlm_eap/types/rlm_eap_mschapv2/rlm_eap_mschapv2.c freeradius-server-2.1.12/src/modules/rlm_eap/types/rlm_eap_mschapv2/rlm_eap_mschapv2.c
>--- freeradius-server-2.1.12-old/src/modules/rlm_eap/types/rlm_eap_mschapv2/rlm_eap_mschapv2.c	2011-09-30 16:12:07.000000000 +0200
>+++ freeradius-server-2.1.12/src/modules/rlm_eap/types/rlm_eap_mschapv2/rlm_eap_mschapv2.c	2014-01-31 19:30:14.106710488 +0100
>@@ -557,11 +557,11 @@
> 	response->vp_strvalue[0] = eap_ds->response->type.data[1];
> 	response->vp_strvalue[1] = eap_ds->response->type.data[5 + MSCHAPV2_RESPONSE_LEN];
> 
>-	name = pairmake("NTLM-User-Name", "", T_OP_EQ);
>+	name = pairmake("MS-CHAP-User-Name", "", T_OP_EQ);
> 	if (!name) {
> 		pairfree(&challenge);
> 		pairfree(&response);
>-		radlog(L_ERR, "rlm_eap_mschapv2: Failed creating NTLM-User-Name: %s", fr_strerror());
>+		radlog(L_ERR, "rlm_eap_mschapv2: Failed creating MS-CHAP-User-Name: %s", fr_strerror());
> 		return 0;
> 	}
> 	
>diff -ru freeradius-server-2.1.12-old/src/modules/rlm_mschap/rlm_mschap.c freeradius-server-2.1.12/src/modules/rlm_mschap/rlm_mschap.c
>--- freeradius-server-2.1.12-old/src/modules/rlm_mschap/rlm_mschap.c	2011-09-30 16:12:07.000000000 +0200
>+++ freeradius-server-2.1.12/src/modules/rlm_mschap/rlm_mschap.c	2014-01-31 19:33:19.001048428 +0100
>@@ -1196,11 +1196,21 @@
> 			username_string = name_attr->vp_strvalue;
> 		}
> 		
>+		/*
>+ 		 *	When the names are ASCII, they should be
>+ 		 *	identical.  When the names are non-ASCII,
>+ 		 *	User-Name is UTF-8, and MS-CHAP-User-Name is
>+ 		 *	some local Windows character set.  So they
>+		 *	can't be identical.  And because you don't
>+		 *	know what the MS-CHAP character set is,
>+		 *	there's no way to do ANY kind of comparison.
>+		 *	They could be "bob" and "doug", and you'd have
>+		 *	no idea.
>+ 		 */
> 		if (response_name &&
> 		    ((username->length != response_name->length) ||
> 		     (strncasecmp(username->vp_strvalue, response_name->vp_strvalue, username->length) != 0))) {
>-			RDEBUG("ERROR: User-Name (%s) is not the same as MS-CHAP Name (%s) from EAP-MSCHAPv2", username->vp_strvalue, response_name->vp_strvalue);
>-			return RLM_MODULE_REJECT;
>+			RDEBUG("WARNING: User-Name (%s) is not the same as MS-CHAP Name (%s) from EAP-MSCHAPv2", username->vp_strvalue, response_name->vp_strvalue);
> 		}
> 
> #ifdef __APPLE__

Actions: View | Diff

Attachments on bug 1060319: 857954