Attachment 859160 Details for Bug 1050964 – Alternative upstream patch: do not call d_path(buflen=0)

[patch] Alternative upstream patch: do not call d_path(buflen=0)

0001-coredump-don-t-call-d_path-with-too-short-a-buffer.patch (text/plain), 1.52 KB, created by Denys Vlasenko on 2014-02-04 13:41:07 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Denys Vlasenko

Created: 2014-02-04 13:41:07 UTC

Size: 1.52 KB

patch

obsolete

>From 3f6e9d16172c5d8c2285e66f360323c13f70c28a Mon Sep 17 00:00:00 2001
>From: Denys Vlasenko <dvlasenk@redhat.com>
>To: linux-kernel@vger.kernel.org
>Date: Tue, 4 Feb 2014 14:22:10 +0100
>Subject: [PATCH] coredump: don't call d_path() with too short a buffer
>
>d_path() does not guarantee correct execution if buflen is 0.
>Before this change, we sometimes call it with zero buffer len,
>resulting in an oops.
>
>Bug reports:
>https://bugzilla.redhat.com/show_bug.cgi?id=1050964
>https://bugzilla.redhat.com/show_bug.cgi?id=1060384
>
>Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
>Cc: Al Viro <viro@ZenIV.linux.org.uk>
>Cc: Oleg Nesterov <oleg@redhat.com>
>Cc: Jan Kratochvil <jan.kratochvil@redhat.com>
>Cc: Amerigo Wang <amwang@redhat.com>
>Cc: "Jonathan M. Foote" <jmfoote@cert.org>
>Cc: Roland McGrath <roland@hack.frob.com>
>Cc: Pedro Alves <palves@redhat.com>
>Cc: Fengguang Wu <fengguang.wu@intel.com>
>Cc: Stephen Rothwell <sfr@canb.auug.org.au>
>---
> fs/binfmt_elf.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
>diff --git a/fs/binfmt_elf.c b/fs/binfmt_elf.c
>index 67be295..7c324c6 100644
>--- a/fs/binfmt_elf.c
>+++ b/fs/binfmt_elf.c
>@@ -1424,7 +1424,9 @@ static int fill_files_note(struct memelfnote *note)
> 		file = vma->vm_file;
> 		if (!file)
> 			continue;
>-		filename = d_path(&file->f_path, name_curpos, remaining);
>+		filename = ERR_PTR(-ENAMETOOLONG);
>+		if (remaining > 1)
>+			filename = d_path(&file->f_path, name_curpos, remaining);
> 		if (IS_ERR(filename)) {
> 			if (PTR_ERR(filename) == -ENAMETOOLONG) {
> 				vfree(data);
>-- 
>1.8.1.4
>

Actions: View | Diff

Attachments on bug 1050964: 851700 | 852718 | 853096 | 859160 | 859769