Attachment 862294 Details for Bug 1050206 – NFSv4: Fix a slot leak in nfs40_sequence_done

[patch] NFSv4: Fix a slot leak in nfs40_sequence_done

0001-NFSv4-Fix-a-slot-leak-in-nfs40_sequence_done.patch (text/plain), 1.11 KB, created by Trond Myklebust on 2014-02-12 13:34:06 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Trond Myklebust

Created: 2014-02-12 13:34:06 UTC

Size: 1.11 KB

patch

obsolete

>From cab92c19821a814ecf5a5279e2699bf28e66caee Mon Sep 17 00:00:00 2001
>From: Trond Myklebust <trond.myklebust@primarydata.com>
>Date: Wed, 29 Jan 2014 12:12:15 -0500
>Subject: [PATCH] NFSv4: Fix a slot leak in nfs40_sequence_done
>
>The check for whether or not we sent an RPC call in nfs40_sequence_done
>is insufficient to decide whether or not we are holding a session slot,
>and thus should not be used to decide when to free that slot.
>
>This patch replaces the RPC_WAS_SENT() test with the correct test for
>whether or not slot == NULL.
>
>Cc: Chuck Lever <chuck.lever@oracle.com>
>Cc: stable@vger.kernel.org # 3.12+
>Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>
>---
> fs/nfs/nfs4proc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
>index ae00c3ed733f..493e9cce1f11 100644
>--- a/fs/nfs/nfs4proc.c
>+++ b/fs/nfs/nfs4proc.c
>@@ -539,7 +539,7 @@ static int nfs40_sequence_done(struct rpc_task *task,
> 	struct nfs4_slot *slot = res->sr_slot;
> 	struct nfs4_slot_table *tbl;
> 
>-	if (!RPC_WAS_SENT(task))
>+	if (slot == NULL)
> 		goto out;
> 
> 	tbl = slot->table;
>-- 
>1.8.5.3
>

Actions: View | Diff

Attachments on bug 1050206: 847339 | 858114 | 862294