Attachment 863524 Details for Bug 1065051 – Patch 3

[patch] Patch 3

0001-dm-thin-synchronize-the-pool-mode-during-suspend.patch (text/plain), 1.47 KB, created by Mike Snitzer on 2014-02-14 23:42:07 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Mike Snitzer

Created: 2014-02-14 23:42:07 UTC

Size: 1.47 KB

patch

obsolete

>From 7d666bb30e3405d55f5a1452b2c3f8882d316257 Mon Sep 17 00:00:00 2001
>From: Mike Snitzer <snitzer@redhat.com>
>Date: Fri, 14 Feb 2014 18:10:55 -0500
>Subject: [PATCH] dm thin: synchronize the pool mode during suspend
>
>Commit b5330655 ("dm thin: handle metadata failures more consistently")
>increased potential for the pool's mode to be changed in response to
>metadata operation failures.
>
>When the pool mode is changed it isn't synchronized with the mode within
>pool_features stored in the target's context (ti->private) that is used
>as the basis for (re)establishing the pool mode in bind_control_target.
>
>It is important that we synchronize the pool mode when suspending
>otherwise the pool may experience and unexpected mode transition on the
>next resume (especially if there was no new table load).
>
>Signed-off-by: Mike Snitzer <snitzer@redhat.com>
>---
> drivers/md/dm-thin.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
>diff --git a/drivers/md/dm-thin.c b/drivers/md/dm-thin.c
>index d501e43..7a2bd14 100644
>--- a/drivers/md/dm-thin.c
>+++ b/drivers/md/dm-thin.c
>@@ -2364,6 +2364,12 @@ static void pool_postsuspend(struct dm_target *ti)
> 	cancel_delayed_work(&pool->waker);
> 	flush_workqueue(pool->wq);
> 	(void) commit(pool);
>+
>+	/*
>+	 * The pool mode may have changed, sync it so bind_control_target()
>+	 * doesn't cause an unexpected mode transition on resume.
>+	 */
>+	pt->adjusted_pf.mode = get_pool_mode(pool);;
> }
> 
> static int check_arg_count(unsigned argc, unsigned args_required)
>-- 
>1.8.1.4
>

Actions: View | Diff

Attachments on bug 1065051: 863191 | 863192 | 863524