Attachment 864414 Details for Bug 1065663 – Fix station leak whena assoc fails

[patch] Fix station leak whena assoc fails

0001-iwlwifi-dvm-clear-IWL_STA_UCODE_INPROGRESS-when-asso.patch (text/plain), 1.32 KB, created by Emmanuel Grumbach on 2014-02-18 08:36:28 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Emmanuel Grumbach

Created: 2014-02-18 08:36:28 UTC

Size: 1.32 KB

patch

obsolete

>From 8968488c7b3e6aadb58d856e8dc7b4423172179a Mon Sep 17 00:00:00 2001
>From: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
>Date: Tue, 18 Feb 2014 10:30:18 +0200
>Subject: [PATCH] iwlwifi: dvm: clear IWL_STA_UCODE_INPROGRESS when assoc fails
>
>We set IWL_STA_UCODE_INPROGRESS flag when we add a station
>and clear it when we send the LQ command for it. But the LQ
>command is sent only when the association succeeds.
>If the association doesn't succeed, we would leave this flag
>set and that wouldn't indicate the station entry as vacant.
>
>This probably fixes:
>https://bugzilla.redhat.com/show_bug.cgi?id=1065663
>
>Change-Id: I1a45e2abb5aeb4f85b149c78daed6629b4f10a16
>Cc: <stable@vger.kernel.org>
>Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
>---
> drivers/net/wireless/iwlwifi/dvm/sta.c | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/drivers/net/wireless/iwlwifi/dvm/sta.c b/drivers/net/wireless/iwlwifi/dvm/sta.c
>index 73c326f..f7e35ea 100644
>--- a/drivers/net/wireless/iwlwifi/dvm/sta.c
>+++ b/drivers/net/wireless/iwlwifi/dvm/sta.c
>@@ -590,6 +590,7 @@ void iwl_deactivate_station(struct iwl_priv *priv, const u8 sta_id,
> 			sizeof(priv->tid_data[sta_id][tid]));
> 
> 	priv->stations[sta_id].used &= ~IWL_STA_DRIVER_ACTIVE;
>+	priv->stations[sta_id].used &= ~IWL_STA_UCODE_INPROGRESS;
> 
> 	priv->num_stations--;
> 
>-- 
>1.8.1.msysgit.1
>

Actions: View | Diff

Attachments on bug 1065663: 863590 | 864414