Attachment 867938 Details for Bug 1069735 – quick fix

[patch] quick fix

0001-spice-prevent-auto-resize-only-when-started-in-fulls.patch (text/plain), 1.86 KB, created by Marc-Andre Lureau on 2014-02-26 11:37:26 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marc-Andre Lureau

Created: 2014-02-26 11:37:26 UTC

Size: 1.86 KB

patch

obsolete

>From 46f0250eb1565fe73832a10fc8867b46f482573d Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= <marcandre.lureau@gmail.com>
>Date: Wed, 26 Feb 2014 12:27:57 +0100
>Subject: [PATCH] spice: prevent auto-resize only when started in fullscreen &
> auto-conf
>
>Auto-resize when going fullscreen is currently blocked if the
>application was started with auto-conf.
>
>Instead, we should block the auto-resize only when starting in
>fullscreen. The patch does that, since app.fullscreen is set back to
>FALSE when leaving fullscreen.
>
>Note: in the virt-viewer upstream, fullscreen & auto-conf behaviours
>have been merged, and the same code is only checking for
>fullscreen. However, in 5.6 we still need to check for both
>properties. Indeed, checking only fullscreen would prevent the guest
>from being auto-resized if the client was started without auto-conf.
>
>https://bugzilla.redhat.com/show_bug.cgi?id=1069735
>---
> src/virt-viewer-display-spice.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
>diff --git a/src/virt-viewer-display-spice.c b/src/virt-viewer-display-spice.c
>index 5eb22cf..c209915 100644
>--- a/src/virt-viewer-display-spice.c
>+++ b/src/virt-viewer-display-spice.c
>@@ -262,9 +262,12 @@ fullscreen_changed(VirtViewerDisplaySpice *self,
>                    VirtViewerApp *app)
> {
>     if (virt_viewer_display_get_fullscreen(VIRT_VIEWER_DISPLAY(self))) {
>-        gboolean auto_conf;
>-        g_object_get(app, "fullscreen-auto-conf", &auto_conf, NULL);
>-        if (auto_conf)
>+        gboolean fullscreen, auto_conf;
>+        g_object_get(app,
>+                     "fullscreen-auto-conf", &auto_conf,
>+                     "fullscreen", &fullscreen,
>+                     NULL);
>+        if (fullscreen && auto_conf)
>             self->priv->auto_resize = AUTO_RESIZE_NEVER;
>         else
>             self->priv->auto_resize = AUTO_RESIZE_FULLSCREEN;
>-- 
>1.8.5.3
>

Flags:

jjongsma: review+

Actions: View | Diff

Attachments on bug 1069735: 867938