Attachment 870281 Details for Bug 1071998 – Fix

[patch] Fix

0001-iwlwifi-mvm-don-t-WARN-when-statistics-are-handled-l.patch (text/plain), 1.38 KB, created by Emmanuel Grumbach on 2014-03-04 08:35:36 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Emmanuel Grumbach

Created: 2014-03-04 08:35:36 UTC

Size: 1.38 KB

patch

obsolete

>From 5abf76e6785f399ca794ef280e3414cd82524eb1 Mon Sep 17 00:00:00 2001
>From: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
>Date: Tue, 4 Mar 2014 10:28:23 +0200
>Subject: [PATCH] iwlwifi: mvm: don't WARN when statistics are handled late
>
>Since the statistics handler is asynchrous, it can very well
>be that we will handle the statistics (hence the RSSI
>fluctuation) when we already disassociated.
>Don't WARN on this case.
>
>This solves: https://bugzilla.redhat.com/show_bug.cgi?id=1071998
>
>Change-Id: Ia969ac90989fa3902698d2e7c858965f15e6c0d3
>Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
>---
> drivers/net/wireless/iwlwifi/mvm/coex.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/net/wireless/iwlwifi/mvm/coex.c b/drivers/net/wireless/iwlwifi/mvm/coex.c
>index b1addeb..bb10340 100644
>--- a/drivers/net/wireless/iwlwifi/mvm/coex.c
>+++ b/drivers/net/wireless/iwlwifi/mvm/coex.c
>@@ -1119,8 +1119,11 @@ void iwl_mvm_bt_rssi_event(struct iwl_mvm *mvm, struct ieee80211_vif *vif,
> 
> 	lockdep_assert_held(&mvm->mutex);
> 
>-	/* Rssi update while not associated ?! */
>-	if (WARN_ON_ONCE(mvmvif->ap_sta_id == IWL_MVM_STATION_COUNT))
>+	/*
>+	 * Rssi update while not associated - can happen since the statistics
>+	 * are handled asynchronously
>+	 */
>+	if (mvmvif->ap_sta_id == IWL_MVM_STATION_COUNT)
> 		return;
> 
> 	/* No BT - reports should be disabled */
>-- 
>1.8.3.2
>

Actions: View | Diff

Attachments on bug 1071998: 870028 | 870281