Attachment 871040 Details for Bug 1072940 – 0001-use-editor.commit_to_preedit-instead-of-deleted-edit.patch

[patch] 0001-use-editor.commit_to_preedit-instead-of-deleted-edit.patch

0001-use-editor.commit_to_preedit-instead-of-deleted-edit.patch (text/plain), 1.40 KB, created by Mike FABIAN on 2014-03-05 15:40:21 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Mike FABIAN

Created: 2014-03-05 15:40:21 UTC

Size: 1.40 KB

patch

obsolete

>From 494d832640a721ca86dff7a244678ebdadcfbd59 Mon Sep 17 00:00:00 2001
>From: Mike FABIAN <mfabian@redhat.com>
>Date: Wed, 5 Mar 2014 16:19:34 +0100
>Subject: [PATCH 1/2] use editor.commit_to_preedit() instead of deleted
> editor.l_shift ()
>
>Resolves: rhbz#1072940 - Left Shift stopped work for ibus-table-1.5.0.20140218-1.fc20.noarch
>See also: https://bugzilla.redhat.com/show_bug.cgi?id=1072940
>
>Was broken by:
>
>https://github.com/kaio/ibus-table/commit/fb11d92439fe4bd55fcad480d3998a17434f6870
>
>commit fb11d92439fe4bd55fcad480d3998a17434f6870
>Author: Caius "kaio" CHANCE <me@kaio.net>
>Date:   Mon May 6 21:05:35 2013 +1000
>
>    Issue #17:
>    Removed excessive instance creation of IBusLookupTable in editor class.
>    Removed
>---
> engine/table.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/engine/table.py b/engine/table.py
>index 3ea0863..c04673c 100644
>--- a/engine/table.py
>+++ b/engine/table.py
>@@ -1660,7 +1660,7 @@ class tabengine (IBus.Engine):
>             return res
>         # process commit to preedit    
>         if self._match_hotkey (key, IBus.KEY_Shift_R, IBus.ModifierType.SHIFT_MASK | IBus.ModifierType.RELEASE_MASK) or self._match_hotkey (key, IBus.KEY_Shift_L, IBus.ModifierType.SHIFT_MASK | IBus.ModifierType.RELEASE_MASK):
>-            res = self._editor.l_shift ()
>+            res = self._editor.commit_to_preedit()
>             self._update_ui ()
>             return res
> 
>-- 
>1.8.5.3
>

Actions: View | Diff

Attachments on bug 1072940: 871040 | 871041 | 873492