Attachment 871041 Details for Bug 1072940 – 0002-Don-t-try-to-set-_prev_char-in-commit_string-when-an.patch

[patch] 0002-Don-t-try-to-set-_prev_char-in-commit_string-when-an.patch

0002-Don-t-try-to-set-_prev_char-in-commit_string-when-an.patch (text/plain), 1.91 KB, created by Mike FABIAN on 2014-03-05 15:41:52 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Mike FABIAN

Created: 2014-03-05 15:41:52 UTC

Size: 1.91 KB

patch

obsolete

>From a1cd0705c8d7c5565d15308e03323fc7a4670f77 Mon Sep 17 00:00:00 2001
>From: Mike FABIAN <mfabian@redhat.com>
>Date: Wed, 5 Mar 2014 16:35:41 +0100
>Subject: [PATCH 2/2] =?UTF-8?q?Don=E2=80=99t=20try=20to=20set=20=5Fprev=5F?=
> =?UTF-8?q?char=20in=20commit=5Fstring()=20when=20an=20empty=20string=20is?=
> =?UTF-8?q?=20committed?=
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>Without this fix one can produce a backtrace by using âwubi-haifeng86â
>and typing âdklâ followed by âShiftâ and âSpaceâ.
>
>After âShiftâ the preÃ«dit is empty and âSpaceâ commits and empty string
>then. This leads to the following backtrace:
>
>Traceback (most recent call last):
>  File "/local/mfabian/src/ibus-table/engine/table.py", line 1589, in do_process_key_event
>    result = self._process_key_event (key)
>  File "/local/mfabian/src/ibus-table/engine/table.py", line 1611, in _process_key_event
>    return self._table_mode_process_key_event (key)
>  File "/local/mfabian/src/ibus-table/engine/table.py", line 1824, in _table_mode_process_key_event
>    self.commit_string (sp_res[1])
>  File "/local/mfabian/src/ibus-table/engine/table.py", line 1516, in commit_string
>    self._prev_char = string[-1]
>IndexError: string index out of range
>---
> engine/table.py | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
>diff --git a/engine/table.py b/engine/table.py
>index c04673c..5f4c483 100644
>--- a/engine/table.py
>+++ b/engine/table.py
>@@ -1511,7 +1511,10 @@ class tabengine (IBus.Engine):
>         self._editor.clear ()
>         self._update_ui ()
>         super(tabengine,self).commit_text(IBus.Text.new_from_string(string))
>-        self._prev_char = string[-1]
>+        if len(string) > 0:
>+            self._prev_char = string[-1]
>+        else:
>+            self._prev_char = None
> 
>     def _convert_to_full_width (self, c):
>         '''convert half width character to full width'''
>-- 
>1.8.5.3
>

Actions: View | Diff

Attachments on bug 1072940: 871040 | 871041 | 873492