Attachment 871336 Details for Bug 1073256 – distro_tags should be a dict

[patch] distro_tags should be a dict

BZ-1073256-distro_tags-should-be-a-dict.patch (text/plain), 1.75 KB, created by Mathieu Bridon on 2014-03-06 10:59:23 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Mathieu Bridon

Created: 2014-03-06 10:59:23 UTC

Size: 1.75 KB

patch

obsolete

>From e5f0902ea42af8b5e3014a3b926cbcd4845e5d58 Mon Sep 17 00:00:00 2001
>From: Mathieu Bridon <bochecha@fedoraproject.org>
>Date: Thu, 6 Mar 2014 18:56:02 +0800
>Subject: [PATCH] distro_tags should be a dict
>
>Everything else in Yum expects this to be a dict.
>
>createrepo's own modifyrepo also expects this to be a dict.
>
>Making it a list here breaks things.
>
>https://bugzilla.redhat.com/show_bug.cgi?id=1073256
>---
> createrepo/__init__.py |    1 +
> genpkgmetadata.py      |    4 ++--
> 2 files changed, 3 insertions(+), 2 deletions(-)
>
>diff --git a/createrepo/__init__.py b/createrepo/__init__.py
>index fb6eaba..abe6fdb 100644
>--- a/createrepo/__init__.py
>+++ b/createrepo/__init__.py
>@@ -103,6 +103,7 @@ class MetaDataConfig(object):
>         self.additional_metadata = {} # dict of 'type':'filename'
>         self.revision = str(int(time.time()))
>         self.content_tags = [] # flat list of strings (like web 2.0 tags)
>+        self.distro_tags = {}# {cpeid(None allowed): human-readable-string}
>         self.distro_tags = []# [(cpeid(None allowed), human-readable-string)]
>         self.repo_tags = []# strings, forwhatever they are worth
>         self.read_pkgs_list = None # filepath/name to write out list of pkgs
>diff --git a/genpkgmetadata.py b/genpkgmetadata.py
>index 5979eff..d0fad14 100755
>--- a/genpkgmetadata.py
>+++ b/genpkgmetadata.py
>@@ -188,10 +188,10 @@ def parse_args(args, conf):
> 
>     for spec in opts.distro:
>         if spec.find(',') == -1:
>-            conf.distro_tags.append((None, spec))
>+            conf.distro_tags[None] = spec
>         else:
>             splitspec = spec.split(',')
>-            conf.distro_tags.append((splitspec[0], splitspec[1]))
>+            conf.distro_tags[splitspec[0]] = splitspec[1]
> 
>     lst = []
>     if conf.pkglist:
>-- 
>1.7.1
>

Actions: View | Diff

Attachments on bug 1073256: 871336 | 871337