Attachment 871337 Details for Bug 1073256 – repoMDObject: tags['distro'] is a dict

[patch] repoMDObject: tags['distro'] is a dict

BZ-1073256-repoMDObject-tags-distro-is-a-dict.patch (text/plain), 1.27 KB, created by Mathieu Bridon on 2014-03-06 11:00:34 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Mathieu Bridon

Created: 2014-03-06 11:00:34 UTC

Size: 1.27 KB

patch

obsolete

>From 72833f0a6618ac41d3a824425aeff287be785f9e Mon Sep 17 00:00:00 2001
>From: Mathieu Bridon <bochecha@fedoraproject.org>
>Date: Thu, 6 Mar 2014 18:48:23 +0800
>Subject: [PATCH] repoMDObject: tags['distro'] is a dict
>
>Everything in this file handles it as a dict, it is declared as a dict,
>etc...
>
>Expecting a list of tuples at this point is very confusing, and
>potentially problematic.
>
>Indeed, createrepo's modifyrepo expects this to be a dict, like the rest
>of this file.
>
>However, createrepo itself expects it to be a list of tuples, so it will
>need to be fixed too.
>
>https://bugzilla.redhat.com/show_bug.cgi?id=1073256
>---
> yum/repoMDObject.py |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/yum/repoMDObject.py b/yum/repoMDObject.py
>index 31b1080..afc7947 100755
>--- a/yum/repoMDObject.py
>+++ b/yum/repoMDObject.py
>@@ -225,7 +225,7 @@ class RepoMD:
>             for item in self.tags['repo']:
>                 tag = """   <repo>%s</repo>\n""" % (to_xml(item))
>                 tags += tag
>-            for (cpeid, item) in self.tags['distro']:
>+            for (cpeid, item) in self.tags['distro'].items():
>                 itemlist = list(item) # frellingsets.
>                 if cpeid:
>                     tag = """   <distro cpeid="%s">%s</distro>\n""" % (
>-- 
>1.7.1
>

Actions: View | Diff

Attachments on bug 1073256: 871336 | 871337