Attachment 871503 Details for Bug 1073517 – adds a new test, also allows test-specific overrides of target bandwidth percentage

[patch] adds a new test, also allows test-specific overrides of target bandwidth percentage

0001-1073517-FEAT-Add-a-new-40Gig-Ethernet-test.patch (text/plain), 2.83 KB, created by Greg Nichols on 2014-03-06 15:21:11 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Greg Nichols

Created: 2014-03-06 15:21:11 UTC

Size: 2.83 KB

patch

obsolete

>From b4b034cc6086d597fe22a0540d5113937a801418 Mon Sep 17 00:00:00 2001
>From: Greg Nichols <gnichols@redhat.com>
>Date: Thu, 6 Mar 2014 10:19:53 -0500
>Subject: [PATCH] 1073517 - FEAT: Add a new 40Gig Ethernet test
>
>---
> hwcert/networkTest.py    | 6 +++---
> tests/network/network.py | 9 +++++++++
> 2 files changed, 12 insertions(+), 3 deletions(-)
>
>diff --git a/hwcert/networkTest.py b/hwcert/networkTest.py
>index f677e18..c0d02f1 100644
>--- a/hwcert/networkTest.py
>+++ b/hwcert/networkTest.py
>@@ -44,6 +44,7 @@ class NetworkTest(Test):
>         self.ignoreInterfaces = re.compile("lo|peth\d+|virbr\d+|vif\d+.\d+|xenbr\d+|wmaster\d+|sit\d+")
>         self.environment = Environment()
>         self.enforceSpeed = False
>+        self.bandwidthTarget = 0.8 # 80%
> 
>     def tags(self):
>         return [TestTag.noninteractive, TestTag.certification, TestTag.network]
>@@ -387,7 +388,6 @@ class NetworkTest(Test):
>     def tcpTestBandwidth(self):
>         print "testing bandwidth to " +  self.getTestServer()
>         messageSize = "1m" # 1 MB
>-        bandwidthTarget = 0.8 # 80%
>         cycles = 5
>         speedErrors = 0
>         for numberOfThreads in [2, 4, 8, 16]:
>@@ -414,7 +414,7 @@ class NetworkTest(Test):
>                     print bw_tcp.errors[0]
>                     bandwidth = float(match.group("bandwidth"))
>                     averageBandwidth = (averageBandwidth*p + bandwidth)/(p+1)
>-            if averageBandwidth*8 > self.interfaceSpeed*bandwidthTarget:
>+            if averageBandwidth*8 > self.interfaceSpeed*self.bandwidthTarget:
>                 print "Average Bandwidth: %s" % averageBandwidth
>                 return True
>             # otherwise
>@@ -422,7 +422,7 @@ class NetworkTest(Test):
>             if self.enforceSpeed:
>                 message = "Error:"
>                 speedErrors += 1
>-            print "%s Average Bandwidth %s Mb/sec is less than %s%% of the interface speed of %s Mb/sec" % (message, averageBandwidth*8, bandwidthTarget*100, self.interfaceSpeed)
>+            print "%s Average Bandwidth %s Mb/sec is less than %s%% of the interface speed of %s Mb/sec" % (message, averageBandwidth*8, self.bandwidthTarget*100, self.interfaceSpeed)
> 
>         if speedErrors:
>             return False
>diff --git a/tests/network/network.py b/tests/network/network.py
>index 7cc9e51..a86c7f7 100644
>--- a/tests/network/network.py
>+++ b/tests/network/network.py
>@@ -79,3 +79,12 @@ class Ethernet10GigTest(EthernetTest):
>         self.interfaceSpeed = 10000 # speed in Mb/sec
>         self.enforceSpeed = True
>         self.serverMode = False
>+
>+class Ethernet40GigTest(EthernetTest):
>+
>+    def __init__(self):
>+        EthernetTest.__init__(self, name="40GigEthernet")
>+        self.interfaceSpeed = 40000 # speed in Mb/sec
>+        self.enforceSpeed = True
>+        self.bandwidthTarget = 0.5 # 50% - override default.
>+        self.serverMode = False
>-- 
>1.8.4.2
>

Actions: View | Diff

Attachments on bug 1073517: 871503 | 886394