Login
[x]
Log in using an account from:
Fedora Account System
Red Hat Associate
Red Hat Customer
Or login using a Red Hat Bugzilla account
Forgot Password
Login:
Hide Forgot
Create an Account
Red Hat Bugzilla – Attachment 874079 Details for
Bug 1074093
Webkitgtk3 crashes on PPC64/AArch64 due to mprotect() on address not aligned to the page size
[?]
New
Simple Search
Advanced Search
My Links
Browse
Requests
Reports
Current State
Search
Tabular reports
Graphical reports
Duplicates
Other Reports
User Changes
Plotly Reports
Bug Status
Bug Severity
Non-Defaults
|
Product Dashboard
Help
Page Help!
Bug Writing Guidelines
What's new
Browser Support Policy
5.0.4.rh83 Release notes
FAQ
Guides index
User guide
Web Services
Contact
Legal
This site requires JavaScript to be enabled to function correctly, please enable it.
[patch]
commitSize_to_be_pageSize.patch
debug_mno.patch (text/plain), 1.91 KB, created by
Michel Normand
on 2014-03-13 17:07:32 UTC
(
hide
)
Description:
commitSize_to_be_pageSize.patch
Filename:
MIME Type:
Creator:
Michel Normand
Created:
2014-03-13 17:07:32 UTC
Size:
1.91 KB
patch
obsolete
>Subject: debug mno >From: Michel Normand <normand@linux.vnet.ibm.com> > >commitSize hardcoded value changed to pageSize >TODO: only a trial ... > >Signed-off-by: Michel Normand <normand@linux.vnet.ibm.com> >--- > Source/JavaScriptCore/interpreter/JSStack.cpp | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > >Index: webkitgtk3/Source/JavaScriptCore/interpreter/JSStack.cpp >=================================================================== >--- webkitgtk3.orig/Source/JavaScriptCore/interpreter/JSStack.cpp >+++ webkitgtk3/Source/JavaScriptCore/interpreter/JSStack.cpp >@@ -49,7 +49,9 @@ JSStack::JSStack(VM& vm, size_t capacity > { > ASSERT(capacity && isPageAligned(capacity)); > >- m_reservation = PageReservation::reserve(roundUpAllocationSize(capacity * sizeof(Register), commitSize), OSAllocator::JSVMStackPages); >+ // TODO how to set it only one time commitSize (replaced here by commitsize) >+ size_t commitsize = pageSize(); >+ m_reservation = PageReservation::reserve(roundUpAllocationSize(capacity * sizeof(Register), commitsize), OSAllocator::JSVMStackPages); > updateStackLimit(highAddress()); > m_commitEnd = highAddress(); > >@@ -76,11 +78,12 @@ bool JSStack::growSlowCase(Register* new > updateStackLimit(newEnd); > return true; > } >- >+ // TODO how to set it only one time commitSize (replaced here by commitsize) >+ size_t commitsize = pageSize(); > // Compute the chunk size of additional memory to commit, and see if we > // have it is still within our budget. If not, we'll fail to grow and > // return false. >- long delta = roundUpAllocationSize(reinterpret_cast<char*>(m_commitEnd) - reinterpret_cast<char*>(newEnd), commitSize); >+ long delta = roundUpAllocationSize(reinterpret_cast<char*>(m_commitEnd) - reinterpret_cast<char*>(newEnd), commitsize); > if (reinterpret_cast<char*>(m_commitEnd) - delta <= reinterpret_cast<char*>(m_useableEnd)) > return false; >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
Attachments on
bug 1074093
: 874079