Attachment 874079 Details for Bug 1074093 – commitSize_to_be_pageSize.patch

[patch] commitSize_to_be_pageSize.patch

debug_mno.patch (text/plain), 1.91 KB, created by Michel Normand on 2014-03-13 17:07:32 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Michel Normand

Created: 2014-03-13 17:07:32 UTC

Size: 1.91 KB

patch

obsolete

>Subject: debug mno
>From: Michel Normand <normand@linux.vnet.ibm.com>
>
>commitSize hardcoded value changed to pageSize
>TODO: only a trial ...
>
>Signed-off-by: Michel Normand <normand@linux.vnet.ibm.com>
>---
> Source/JavaScriptCore/interpreter/JSStack.cpp |    9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
>Index: webkitgtk3/Source/JavaScriptCore/interpreter/JSStack.cpp
>===================================================================
>--- webkitgtk3.orig/Source/JavaScriptCore/interpreter/JSStack.cpp
>+++ webkitgtk3/Source/JavaScriptCore/interpreter/JSStack.cpp
>@@ -49,7 +49,9 @@ JSStack::JSStack(VM& vm, size_t capacity
> {
>     ASSERT(capacity && isPageAligned(capacity));
> 
>-    m_reservation = PageReservation::reserve(roundUpAllocationSize(capacity * sizeof(Register), commitSize), OSAllocator::JSVMStackPages);
>+    // TODO how to set it only one time commitSize (replaced here by commitsize)
>+    size_t commitsize = pageSize();
>+    m_reservation = PageReservation::reserve(roundUpAllocationSize(capacity * sizeof(Register), commitsize), OSAllocator::JSVMStackPages);
>     updateStackLimit(highAddress());
>     m_commitEnd = highAddress();
>     
>@@ -76,11 +78,12 @@ bool JSStack::growSlowCase(Register* new
>         updateStackLimit(newEnd);
>         return true;
>     }
>-
>+    // TODO how to set it only one time commitSize (replaced here by commitsize)
>+    size_t commitsize = pageSize();
>     // Compute the chunk size of additional memory to commit, and see if we
>     // have it is still within our budget. If not, we'll fail to grow and
>     // return false.
>-    long delta = roundUpAllocationSize(reinterpret_cast<char*>(m_commitEnd) - reinterpret_cast<char*>(newEnd), commitSize);
>+    long delta = roundUpAllocationSize(reinterpret_cast<char*>(m_commitEnd) - reinterpret_cast<char*>(newEnd), commitsize);
>     if (reinterpret_cast<char*>(m_commitEnd) - delta <= reinterpret_cast<char*>(m_useableEnd))
>         return false;
>

Actions: View | Diff

Attachments on bug 1074093: 874079