Attachment 874151 Details for Bug 1046197 – kerberos memory leak fixes

[patch] kerberos memory leak fixes

gnome-online-accounts-memleak.patch (text/plain), 1.71 KB, created by Michael Cronenworth on 2014-03-13 20:14:14 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Michael Cronenworth

Created: 2014-03-13 20:14:14 UTC

Size: 1.71 KB

patch

obsolete

>--- gnome-online-accounts-3.10.2.orig/src/goaidentity/goakerberosidentity.c	2013-11-12 10:09:30.000000000 -0600
>+++ gnome-online-accounts-3.10.2/src/goaidentity/goakerberosidentity.c	2014-03-13 15:03:17.280288261 -0500
>@@ -294,6 +294,7 @@
> 
>   identifier = g_strdup (unparsed_name);
>   krb5_free_unparsed_name (self->priv->kerberos_context, unparsed_name);
>+  krb5_free_principal (self->priv->kerberos_context, principal);
> 
>   return identifier;
> }
>@@ -635,12 +636,16 @@
>             verification_level = VERIFICATION_LEVEL_EXISTS;
>         }
> 
>+      krb5_free_cred_contents (self->priv->kerberos_context, &credentials);
>+
>       error_code = krb5_cc_next_cred (self->priv->kerberos_context,
>                                       self->priv->credentials_cache,
>                                       &cursor,
>                                       &credentials);
>     }
> 
>+  krb5_free_cred_contents (self->priv->kerberos_context, &credentials);
>+
>   if (error_code != KRB5_CC_END)
>     {
>       verification_level = VERIFICATION_LEVEL_ERROR;
>@@ -787,11 +792,11 @@
> 
>       new_cancellable = g_cancellable_new ();
>       goa_alarm_set_time (alarm, alarm_time, new_cancellable);
>-      g_date_time_unref (alarm_time);
> 
>       g_clear_object (cancellable);
>       *cancellable = new_cancellable;
>     }
>+  g_date_time_unref (alarm_time);
>   G_UNLOCK (identity_lock);
> 
> }
>@@ -860,6 +865,7 @@
>   now = g_date_time_new_now_local ();
>   expiration_time = g_date_time_new_from_unix_local (self->priv->expiration_time);
>   time_span_until_expiration = g_date_time_difference (expiration_time, now);
>+  g_date_time_unref (now);
> 
>   /* Let the user reauthenticate 10 min before expiration */
>   expiring_time = g_date_time_add_minutes (expiration_time, -10);

Actions: View | Diff

Attachments on bug 1046197: 870108 | 874151