Attachment 874823 Details for Bug 1076836 – 3.14.0-0.rc6.git4.1.fc21.x86_64 resume circular locking dependency

3.14.0-0.rc6.git4.1.fc21.x86_64 resume circular locking dependency

3.14.0-0.rc6.git4.1.fc21.x86_64-resume-circular-locking-dependency (text/plain), 5.85 KB, created by poma on 2014-03-15 15:54:51 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: poma

Created: 2014-03-15 15:54:51 UTC

Size: 5.85 KB

patch

obsolete

>
>Refers to:
>https://bugzilla.redhat.com/show_bug.cgi?id=1010764
>http://marc.info/?l=linux-kernel&m=139271853617439
>
>Recovery device after resume, now even that's wrong!?
>WTF
>
>
>http://koji.fedoraproject.org/koji/buildinfo?buildID=504536
>kernel-3.14.0-0.rc6.git4.1.fc21.x86_64
>"v3.14-rc6-133-gc60f7d5"
>
>
>/etc/systemd/system/suspend.target.wants/reset-on-resume-DGE-528T-RTL8110s-r8169.service:
>[Unit]
>Description=resume action - reset a pci device
>After=suspend.target
>
>[Service]
>Type=simple
>ExecStart=/usr/bin/enp1s9-reset
>
>[Install]
>WantedBy=suspend.target
>EOF
>
>
>/usr/bin/enp1s9-reset:
>#!/bin/sh
>PATH="/usr/bin:$PATH"
>
># lspci -s 01:09.0
># 01:09.0 Ethernet controller: D-Link System Inc DGE-528T Gigabit Ethernet Adapter (rev 10)
>
># lspci -tv
># ...
># -[0000:00]-
># ...
>#            +-08.0-[01]--
>#            ...
>#            |            \-09.0  D-Link System Inc DGE-528T Gigabit Ethernet Adapter
># ...
>
>/usr/bin/echo 1 > /sys/bus/pci/devices/0000\:01\:09.0/remove
>/usr/bin/echo 1 > /sys/bus/pci/devices/0000\:00\:08.0/rescan
>
>exit 0
>EOF
>
>$ systemctl suspend
>i.e.
># echo none > /sys/power/pm_test
># echo mem > /sys/power/state
>
>
>========== RESUME ==========
>
>
>dmesg:
>...
>======================================================
>[ INFO: possible circular locking dependency detected ]
>3.14.0-0.rc6.git4.1.fc21.x86_64 #1 Not tainted
>-------------------------------------------------------
>kworker/u16:15/1521 is trying to acquire lock:
> (s_active#262){++++.+}, at: [<ffffffff812c03e8>] kernfs_addrm_finish+0x38/0x60
>
>but task is already holding lock:
> (pci_rescan_remove_lock){+.+.+.}, at: [<ffffffff81406c77>] pci_lock_rescan_remove+0x17/0x20
>
>which lock already depends on the new lock.
>
>
>the existing dependency chain (in reverse order) is:
>
>-> #1 (pci_rescan_remove_lock){+.+.+.}:
>       [<ffffffff810fb3f2>] lock_acquire+0xa2/0x1d0
>       [<ffffffff817d7107>] mutex_lock_nested+0x87/0x430
>       [<ffffffff81406c77>] pci_lock_rescan_remove+0x17/0x20
>       [<ffffffff814110c5>] dev_rescan_store+0x65/0x90
>       [<ffffffff814f65b8>] dev_attr_store+0x18/0x30
>       [<ffffffff812bd0c4>] sysfs_kf_write+0x44/0x60
>       [<ffffffff812c16c5>] kernfs_fop_write+0xd5/0x150
>       [<ffffffff8123353d>] vfs_write+0xbd/0x1f0
>       [<ffffffff81233fe8>] SyS_write+0x58/0xd0
>       [<ffffffff817e5829>] system_call_fastpath+0x16/0x1b
>
>-> #0 (s_active#262){++++.+}:
>       [<ffffffff810fa82f>] __lock_acquire+0x186f/0x1c40
>       [<ffffffff810fb3f2>] lock_acquire+0xa2/0x1d0
>       [<ffffffff812bf650>] kernfs_deactivate+0x1b0/0x1c0
>       [<ffffffff812c03e8>] kernfs_addrm_finish+0x38/0x60
>       [<ffffffff812c0680>] kernfs_remove_by_name_ns+0x60/0xc0
>       [<ffffffff812be171>] remove_files.isra.1+0x41/0x80
>       [<ffffffff812be467>] sysfs_remove_group+0x47/0xa0
>       [<ffffffff812be593>] sysfs_remove_groups+0x33/0x50
>       [<ffffffff814f697e>] device_remove_attrs+0x5e/0x80
>       [<ffffffff814f75be>] device_del+0x12e/0x1d0
>       [<ffffffff814097a0>] pci_remove_bus_device+0x70/0xd0
>       [<ffffffff81409842>] pci_stop_and_remove_bus_device_locked+0x22/0x30
>       [<ffffffff814120c5>] remove_callback+0x15/0x20
>       [<ffffffff812bd284>] sysfs_schedule_callback_work+0x14/0x60
>       [<ffffffff810bba30>] process_one_work+0x220/0x6f0
>       [<ffffffff810bc01b>] worker_thread+0x11b/0x3a0
>       [<ffffffff810c43bf>] kthread+0xff/0x120
>       [<ffffffff817e577c>] ret_from_fork+0x7c/0xb0
>
>other info that might help us debug this:
>
> Possible unsafe locking scenario:
>
>       CPU0                    CPU1
>       ----                    ----
>  lock(pci_rescan_remove_lock);
>                               lock(s_active#262);
>                               lock(pci_rescan_remove_lock);
>  lock(s_active#262);
>
> *** DEADLOCK ***
>
>3 locks held by kworker/u16:15/1521:
> #0:  ("%s"("sysfsd")){.+.+.+}, at: [<ffffffff810bb9c4>] process_one_work+0x1b4/0x6f0
> #1:  ((&ss->work)){+.+.+.}, at: [<ffffffff810bb9c4>] process_one_work+0x1b4/0x6f0
> #2:  (pci_rescan_remove_lock){+.+.+.}, at: [<ffffffff81406c77>] pci_lock_rescan_remove+0x17/0x20
>
>stack backtrace:
>CPU: 2 PID: 1521 Comm: kworker/u16:15 Not tainted 3.14.0-0.rc6.git4.1.fc21.x86_64 #1
>Hardware name: Gigabyte Technology Co., Ltd. M720-US3/M720-US3, BIOS F7n 09/07/2010
>Workqueue: sysfsd sysfs_schedule_callback_work
> 0000000000000000 0000000099583d14 ffff8800a2907930 ffffffff817d19a8
> ffffffff8264ccd0 ffff8800a2907970 ffffffff817cce80 ffff8800a29079d0
> ffff8800a664beb8 0000000000000002 ffff8800a664beb8 0000000000000003
>Call Trace:
> [<ffffffff817d19a8>] dump_stack+0x4d/0x66
> [<ffffffff817cce80>] print_circular_bug+0x201/0x20f
> [<ffffffff810fa82f>] __lock_acquire+0x186f/0x1c40
> [<ffffffff810f89b9>] ? mark_held_locks+0xb9/0x140
> [<ffffffff810fb3f2>] lock_acquire+0xa2/0x1d0
> [<ffffffff812c03e8>] ? kernfs_addrm_finish+0x38/0x60
> [<ffffffff812bf650>] kernfs_deactivate+0x1b0/0x1c0
> [<ffffffff812c03e8>] ? kernfs_addrm_finish+0x38/0x60
> [<ffffffff810f89b9>] ? mark_held_locks+0xb9/0x140
> [<ffffffff810f89b9>] ? mark_held_locks+0xb9/0x140
> [<ffffffff812c03e8>] kernfs_addrm_finish+0x38/0x60
> [<ffffffff812c0680>] kernfs_remove_by_name_ns+0x60/0xc0
> [<ffffffff812be171>] remove_files.isra.1+0x41/0x80
> [<ffffffff812be467>] sysfs_remove_group+0x47/0xa0
> [<ffffffff812be593>] sysfs_remove_groups+0x33/0x50
> [<ffffffff814f697e>] device_remove_attrs+0x5e/0x80
> [<ffffffff814f75be>] device_del+0x12e/0x1d0
> [<ffffffff814097a0>] pci_remove_bus_device+0x70/0xd0
> [<ffffffff81409842>] pci_stop_and_remove_bus_device_locked+0x22/0x30
> [<ffffffff814120c5>] remove_callback+0x15/0x20
> [<ffffffff812bd284>] sysfs_schedule_callback_work+0x14/0x60
> [<ffffffff810bba30>] process_one_work+0x220/0x6f0
> [<ffffffff810bb9c4>] ? process_one_work+0x1b4/0x6f0
> [<ffffffff810bc01b>] worker_thread+0x11b/0x3a0
> [<ffffffff810bbf00>] ? process_one_work+0x6f0/0x6f0
> [<ffffffff810c43bf>] kthread+0xff/0x120
> [<ffffffff810c42c0>] ? insert_kthread_work+0x80/0x80
> [<ffffffff817e577c>] ret_from_fork+0x7c/0xb0
> [<ffffffff810c42c0>] ? insert_kthread_work+0x80/0x80
>...
>
>

Actions: View

Attachments on bug 1076836: 874823