Attachment 875615 Details for Bug 1076833 – Patch to fix this bug, v1

Patch to fix this bug, v1

0001-Unconditionally-check-for-group-readability-and-set-.patch (text/plain), 2.39 KB, created by Dave Wysochanski on 2014-03-17 18:09:50 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Dave Wysochanski

Created: 2014-03-17 18:09:50 UTC

Size: 2.39 KB

patch

obsolete

>From 138a452948144ce5bdc5ee1de01a88bda954315a Mon Sep 17 00:00:00 2001
>From: Dave Wysochanski <dwysocha@redhat.com>
>Date: Mon, 17 Mar 2014 14:04:23 -0400
>Subject: [PATCH] Unconditionally check for group readability and set group readable if necessary.
>
>Should fix https://bugzilla.redhat.com/show_bug.cgi?id=1076833
>
>Signed-off-by: Dave Wysochanski <dwysocha@redhat.com>
>---
> src/lib/retrace.py |   18 +++++++++---------
> 1 files changed, 9 insertions(+), 9 deletions(-)
>
>diff --git a/src/lib/retrace.py b/src/lib/retrace.py
>index aa2712f..1f8e6fb 100644
>--- a/src/lib/retrace.py
>+++ b/src/lib/retrace.py
>@@ -1737,6 +1737,15 @@ class RetraceTask:
>                 else:
>                     log_debug("Vmcore dump level is %d" % dump_level)
> 
>+                st = os.stat(vmcore)
>+                if (st.st_mode & stat.S_IRGRP) == 0:
>+                    try:
>+                        os.chmod(vmcore, st.st_mode | stat.S_IRGRP)
>+                    except Exception as ex:
>+                        log_warn("File '%s' is not group readable and chmod"
>+                                 " failed. The process will continue but if"
>+                                 " it fails this is the likely cause."
>+                                 % vmcore)
>                 skip_makedumpfile = CONFIG["VmcoreDumpLevel"] <= 0 or CONFIG["VmcoreDumpLevel"] >= 32
>                 if (dump_level is not None and
>                     (dump_level & CONFIG["VmcoreDumpLevel"]) == CONFIG["VmcoreDumpLevel"]):
>@@ -1748,15 +1757,6 @@ class RetraceTask:
>                     start = time.time()
>                     strip_vmcore(vmcore, kernelver)
>                     dur = int(time.time() - start)
>-                    st = os.stat(vmcore)
>-                    if (st.st_mode & stat.S_IRGRP) == 0:
>-                        try:
>-                            os.chmod(vmcore, st.st_mode | stat.S_IRGRP)
>-                        except Exception as ex:
>-                            log_warn("File '%s' is not group readable and chmod"
>-                                     " failed. The process will continue but if"
>-                                     " it fails this is the likely cause."
>-                                     % vmcore)
> 
>                     log_info("Stripped size: %s" % human_readable_size(st.st_size))
>                     log_info("Makedumpfile took %d seconds and saved %s" % (dur, human_readable_size(oldsize - st.st_size)))
>-- 
>1.7.1
>

Actions: View

Attachments on bug 1076833: 875615 | 888095