Attachment 876157 Details for Bug 1077642 – Patch to fix uid checks and privilege dropping

[patch] Patch to fix uid checks and privilege dropping

file_1077642.txt (text/plain), 1.07 KB, created by William Brown on 2014-03-18 23:56:21 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: William Brown

Created: 2014-03-18 23:56:21 UTC

Size: 1.07 KB

patch

obsolete

>diff -uNrp amanda-3.3.3.orig/amandad-src/amandad.c amanda-3.3.3.work/amandad-src/amandad.c
>--- amanda-3.3.3.orig/amandad-src/amandad.c	2013-01-10 23:24:46.000000000 +1030
>+++ amanda-3.3.3.work/amandad-src/amandad.c	2014-03-19 10:00:39.731689233 +1030
>@@ -456,7 +456,8 @@ main(
>     }
> 
> #ifndef SINGLE_USERID
>-    if (geteuid() == 0) {
>+    //if (geteuid() == 0) {
>+    if (getuid() == 0) {
> 	if (strcasecmp(auth, "krb5") != 0) {
> 	    struct passwd *pwd;
> 	    /* lookup our local user name */
>@@ -1554,6 +1555,7 @@ service_new(
>     struct active_service *as;
>     pid_t pid;
>     int newfd;
>+    struct passwd *pwd;
>     char *peer_name;
>     char *amanda_remote_host_env[2];
> 
>@@ -1768,6 +1770,9 @@ service_new(
>         aclose(data_write[STDERR_PIPE][1]);
> 	safe_fd(DATA_FD_OFFSET, DATA_FD_COUNT*2);
> 
>+        pwd = getpwnam(CLIENT_LOGIN);
>+        setreuid(pwd->pw_uid, pwd->pw_uid);
>+
> 	execle(cmd, cmd, "amandad", auth, (char *)NULL, safe_env_full(amanda_remote_host_env));
> 	error(_("could not exec service %s: %s\n"), cmd, strerror(errno));
> 	/*NOTREACHED*/

Actions: View | Diff

Attachments on bug 1077642: 875869 | 875872 | 876157 | 881614