Attachment 878982 Details for Bug 1080806 – Patch proposal

[patch] Patch proposal

BZ-1080806.patch (text/plain), 2.48 KB, created by Martin Weiler on 2014-03-26 12:36:41 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Weiler

Created: 2014-03-26 12:36:41 UTC

Size: 2.48 KB

patch

obsolete

>commit 6fbf97eb23317033cd3f6c1c5d64200d8484f741
>Author: Martin Weiler <mweiler@redhat.com>
>Date:   Wed Mar 26 10:00:52 2014 +0100
>
>    BZ 1080806: HornetQTaskClientConnector and BaseHornteQTaskServer not acknowledging received messages
>
>diff --git jbpm-human-task/src/main/java/org/jbpm/task/service/hornetq/BaseHornetQTaskServer.java jbpm-human-task/src/main/java/org/jbpm/task/service/hornetq/BaseHornetQTaskServer.java
>index 32d6ad6..285495d 100644
>--- jbpm-human-task/src/main/java/org/jbpm/task/service/hornetq/BaseHornetQTaskServer.java
>+++ jbpm-human-task/src/main/java/org/jbpm/task/service/hornetq/BaseHornetQTaskServer.java
>@@ -103,6 +103,11 @@ public abstract class BaseHornetQTaskServer extends TaskServer {
> 					String clientId = clientMessage.getStringProperty("producerId");
> 					handler.messageReceived(session, object, clientId);
> 				}
>+                clientMessage.acknowledge();
>+                session.commit();
>+                if(logger.isTraceEnabled()) {
>+                    logger.trace("clientMessage " + clientMessage + " consumed and ack'd with commit");
>+                }
> 			}
> 		}
> 		catch (HornetQException e) {
>@@ -204,4 +209,4 @@ public abstract class BaseHornetQTaskServer extends TaskServer {
> 	public boolean isRunning() {
> 		return running;
> 	}
>-}
>\ No newline at end of file
>+}
>diff --git jbpm-human-task/src/main/java/org/jbpm/task/service/hornetq/HornetQTaskClientConnector.java jbpm-human-task/src/main/java/org/jbpm/task/service/hornetq/HornetQTaskClientConnector.java
>index 807dfc1..8ea4883 100644
>--- jbpm-human-task/src/main/java/org/jbpm/task/service/hornetq/HornetQTaskClientConnector.java
>+++ jbpm-human-task/src/main/java/org/jbpm/task/service/hornetq/HornetQTaskClientConnector.java
>@@ -121,6 +121,11 @@ public class HornetQTaskClientConnector implements TaskClientConnector {
>                         if (serverMessage != null) {
>                             ((HornetQTaskClientHandler) handler).messageReceived(session, readMessage(serverMessage), BaseHornetQTaskServer.SERVER_TASK_COMMANDS_QUEUE);
>                         }
>+                        serverMessage.acknowledge();
>+                        session.commit();
>+                        if(logger.isTraceEnabled()) {
>+                            logger.trace("serverMessage " + serverMessage + " consumed and ack'd with commit");
>+                        }
>                     } catch (HornetQException e) {
>                         if (e.getCode() == HornetQException.OBJECT_CLOSED) {
>                         	try {

Actions: View | Diff

Attachments on bug 1080806: 878894 | 878982