Attachment 882699 Details for Bug 1084414 – evo leaks patch

[patch] evo leaks patch

evo-leaks.patch (text/plain), 2.36 KB, created by Milan Crha on 2014-04-04 13:06:15 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Milan Crha

Created: 2014-04-04 13:06:15 UTC

Size: 2.36 KB

patch

obsolete

>Index: e-util/e-file-request.c
>===================================================================
>--- e-util/e-file-request.c	(revision 1)
>+++ e-util/e-file-request.c	(working copy)
>@@ -60,7 +60,7 @@ handle_file_request (GSimpleAsyncResult *res,
> 
> 		stream = g_memory_input_stream_new_from_data (
> 				contents, length, (GDestroyNotify) g_free);
>-		g_simple_async_result_set_op_res_gpointer (res, stream, NULL);
>+		g_simple_async_result_set_op_res_gpointer (res, stream, g_object_unref);
> 	}
> }
> 
>@@ -130,6 +130,8 @@ file_request_send_finish (SoupRequest *request,
> 
> 	if (!stream) /* We must always return something */
> 		stream = g_memory_input_stream_new ();
>+	else
>+		g_object_ref (stream);
> 
> 	return stream;
> }
>Index: mail/e-http-request.c
>===================================================================
>--- mail/e-http-request.c	(revision 1)
>+++ mail/e-http-request.c	(working copy)
>@@ -259,7 +259,7 @@ handle_http_request (GSimpleAsyncResult *res,
> 			g_free (path);
> 
> 			/* Set result and quit the thread */
>-			g_simple_async_result_set_op_res_gpointer (res, stream, NULL);
>+			g_simple_async_result_set_op_res_gpointer (res, stream, g_object_unref);
> 
> 			goto cleanup;
> 		} else {
>@@ -415,7 +415,7 @@ handle_http_request (GSimpleAsyncResult *res,
> 			uri, request->priv->content_type,
> 			request->priv->content_length, uri_md5));
> 
>-		g_simple_async_result_set_op_res_gpointer (res, stream, NULL);
>+		g_simple_async_result_set_op_res_gpointer (res, stream, g_object_unref);
> 		goto cleanup;
> 	}
> 
>@@ -526,6 +526,8 @@ http_request_send_finish (SoupRequest *request,
> 
> 	if (!stream) /* We must always return something */
> 		stream = g_memory_input_stream_new ();
>+	else
>+		g_object_ref (stream);
> 
> 	return stream;
> }
>Index: mail/em-folder-tree.c
>===================================================================
>--- mail/em-folder-tree.c	(revision 1)
>+++ mail/em-folder-tree.c	(working copy)
>@@ -3107,6 +3107,8 @@ em_folder_tree_select_next_path (EMFolderTree *fol
> 		/* TODO : Flags here for better options */
> 		} while (skip_read_folders && unread <=0 &&
> 			gtk_tree_path_compare (current_path, path));
>+
>+		gtk_tree_path_free (current_path);
> 	}
> 
> 	if (path) {
>@@ -3120,6 +3122,8 @@ em_folder_tree_select_next_path (EMFolderTree *fol
> 			priv->cursor_set = TRUE;
> 		}
> 		gtk_tree_view_scroll_to_cell (tree_view, path, NULL, TRUE, 0.5f, 0.0f);
>+
>+		gtk_tree_path_free (path);
> 	}
> 	return;
> }

Actions: View | Diff

Attachments on bug 1084414: 882699 | 884542 | 889221 | 889381 | 890503