Attachment 883863 Details for Bug 1080331 – fix for group install

[patch] fix for group install

0001-fix-group-install-RhBug-1080331.patch (text/plain), 1.89 KB, created by Tim Lauridsen on 2014-04-08 05:25:37 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tim Lauridsen

Created: 2014-04-08 05:25:37 UTC

Size: 1.89 KB

patch

obsolete

>From b710c14e766c464173fbcf74c61fef9b373565f2 Mon Sep 17 00:00:00 2001
>From: Tim Lauridsen <timlau@fedoraproject.org>
>Date: Tue, 8 Apr 2014 07:23:01 +0200
>Subject: [PATCH] fix group install (RhBug #1080331)
>
>---
> dnf/cli/commands/group.py | 15 ++++++++-------
> 1 file changed, 8 insertions(+), 7 deletions(-)
>
>diff --git a/dnf/cli/commands/group.py b/dnf/cli/commands/group.py
>index 17ae8e2..9a2e6db 100644
>--- a/dnf/cli/commands/group.py
>+++ b/dnf/cli/commands/group.py
>@@ -88,11 +88,18 @@ class GroupCommand(commands.Command):
>     def _install(self, extcmds):
>         cnt = 0
>         types, patterns = self._split_extcmds(extcmds)
>+        found = False
>         for env in self._patterns2environments(patterns):
>+            found = True
>             cnt += self.base.environment_install(env, types)
>         for grp in self._patterns2groups(patterns):
>+            found = True
>             cnt += self.base.group_install(grp, types)
>-        if not cnt:
>+        if not found:
>+            msg = _("No relevant match for the specified '%s'.")
>+            msg = msg % to_unicode(pat)
>+            raise dnf.cli.CliError(msg)
>+        elif not cnt:
>             msg = _('No packages in any requested groups available to install.')
>             raise dnf.cli.CliError(msg)
> 
>@@ -122,16 +129,10 @@ class GroupCommand(commands.Command):
>     def _patterns2(fn, patterns, fltr):
>         for pat in patterns:
>             grps = fn(pat)
>-            cnt = 0
>             for grp in grps:
>                 if not fltr(grp):
>                     continue
>                 yield grp
>-                cnt += 1
>-            if not cnt:
>-                msg = _("No relevant match for the specified '%s'.")
>-                msg = msg % to_unicode(pat)
>-                raise dnf.cli.CliError(msg)
> 
>     def _patterns2environments(self, patterns, fltr=lambda grp: True):
>         fn = self.base.comps.environments_by_pattern
>-- 
>1.9.0
>

Actions: View | Diff

Attachments on bug 1080331: 883863 | 883876 | 883877 | 883892