Attachment 883890 Details for Bug 1083744 – Patch - check for non existent negative entries in lookup_ghost()

[patch] Patch - check for non existent negative entries in lookup_ghost()

autofs-5.0.9-check-for-non-existent-negative-entries-in-lookup_ghost.patch (text/plain), 1.62 KB, created by Ian Kent on 2014-04-08 06:19:55 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Ian Kent

Created: 2014-04-08 06:19:55 UTC

Size: 1.62 KB

patch

obsolete

>autofs-5.0.9 - check for non existent negative entries in lookup_ghost()
>
>From: Ian Kent <raven@themaw.net>
>
>Map entries that have been created in the cache due to a negative lookup
>but don't exist in the map source shouldn't have directories created.
>
>This can be detected by checking me->status.
>
>For negative entries that are present in the map source me->status will
>have been set to 0 in lookup_prune_one_cache() and negavive entries that
>have been created in the same second as the map read will always have
>me->status > 0 and so will also be skipped by lookup_ghost().
>---
> daemon/lookup.c |   13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
>--- autofs-5.0.5.orig/daemon/lookup.c
>+++ autofs-5.0.5/daemon/lookup.c
>@@ -594,6 +594,17 @@ int lookup_ghost(struct autofs_point *ap
> 		cache_readlock(mc);
> 		me = cache_enumerate(mc, NULL);
> 		while (me) {
>+			/*
>+			 * Map entries that have been created in the cache
>+			 * due to a negative lookup but don't exist in the
>+			 * map source shouldn't have directories created.
>+			 * me->status of negative entries that are present
>+			 * in the map source will have me->status set to 0
>+			 * in lookup_prune_one_cache().
>+			 */
>+			if (me->status && !me->mapent)
>+				goto next;
>+
> 			if (!strcmp(me->key, "*"))
> 				goto next;
> 
>@@ -1093,7 +1104,10 @@ void lookup_prune_one_cache(struct autof
> 
> 		if (valid)
> 			cache_delete(mc, key);
>-		else if (!is_mounted(_PROC_MOUNTS, path, MNTS_AUTOFS)) {
>+		else if (me->status) {
>+			cache_unlock(mc);
>+			goto next;
>+		} else if (!is_mounted(_PROC_MOUNTS, path, MNTS_AUTOFS)) {
> 			dev_t devid = ap->dev;
> 			status = CHE_FAIL;
> 			if (ap->type == LKP_DIRECT)

Actions: View | Diff

Attachments on bug 1083744: 882008 | 882079 | 883889 | 883890 | 883929 | 889191 | 893513