Attachment 883935 Details for Bug 1058297 – patch fixing the issue

[patch] patch fixing the issue

0001-Do-not-try-to-del-the-file-object-1058297.patch (text/plain), 998 bytes, created by Vratislav Podzimek on 2014-04-08 09:17:55 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Vratislav Podzimek

Created: 2014-04-08 09:17:55 UTC

Size: 998 bytes

patch

obsolete

>From f17d13d0b5b02a2439fb7806d190a567209f297a Mon Sep 17 00:00:00 2001
>From: Vratislav Podzimek <vpodzime@redhat.com>
>Date: Tue, 8 Apr 2014 11:12:05 +0200
>Subject: [PATCH] Do not try to del() the file object (#1058297)
>
>The file object is created in the scope of the function, so its ref counter is
>decreased few lines below anyway. Forcing del() here seems to cause weird
>issues.
>
>Signed-off-by: Vratislav Podzimek <vpodzime@redhat.com>
>---
> yum/misc.py | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
>diff --git a/yum/misc.py b/yum/misc.py
>index 347a07a..52ee738 100644
>--- a/yum/misc.py
>+++ b/yum/misc.py
>@@ -360,8 +360,7 @@ def checksum(sumtype, file, CHUNK=2**16, datasize=None):
> 
>         if type(file) is types.StringType:
>             fo.close()
>-            del fo
>-            
>+
>         # This screws up the length, but that shouldn't matter. We only care
>         # if this checksum == what we expect.
>         if datasize is not None and datasize != data.length:
>-- 
>1.9.0
>

Actions: View | Diff

Attachments on bug 1058297: 856051 | 856052 | 856053 | 856054 | 856055 | 856056 | 856057 | 856058 | 856059 | 856060 | 856061 | 873363 | 883935 | 885359 | 885360 | 885361 | 885362 | 885363 | 885364 | 885366 | 886071