Attachment 884542 Details for Bug 1084414 – evo patch ][

[patch] evo patch ][

evo-leaks.patch (text/plain), 5.48 KB, created by Milan Crha on 2014-04-09 15:05:13 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Milan Crha

Created: 2014-04-09 15:05:13 UTC

Size: 5.48 KB

patch

obsolete

>diff -up evolution-3.8.5/e-util/e-file-request.c.evo-leaks evolution-3.8.5/e-util/e-file-request.c
>--- evolution-3.8.5/e-util/e-file-request.c.evo-leaks	2013-07-23 14:52:11.000000000 +0200
>+++ evolution-3.8.5/e-util/e-file-request.c	2014-04-09 15:51:31.249060833 +0200
>@@ -60,7 +60,7 @@ handle_file_request (GSimpleAsyncResult
> 
> 		stream = g_memory_input_stream_new_from_data (
> 				contents, length, (GDestroyNotify) g_free);
>-		g_simple_async_result_set_op_res_gpointer (res, stream, NULL);
>+		g_simple_async_result_set_op_res_gpointer (res, stream, g_object_unref);
> 	}
> }
> 
>@@ -130,6 +130,8 @@ file_request_send_finish (SoupRequest *r
> 
> 	if (!stream) /* We must always return something */
> 		stream = g_memory_input_stream_new ();
>+	else
>+		g_object_ref (stream);
> 
> 	return stream;
> }
>diff -up evolution-3.8.5/mail/e-http-request.c.evo-leaks evolution-3.8.5/mail/e-http-request.c
>--- evolution-3.8.5/mail/e-http-request.c.evo-leaks	2013-08-01 14:12:41.000000000 +0200
>+++ evolution-3.8.5/mail/e-http-request.c	2014-04-09 15:51:31.249060833 +0200
>@@ -259,7 +259,7 @@ handle_http_request (GSimpleAsyncResult
> 			g_free (path);
> 
> 			/* Set result and quit the thread */
>-			g_simple_async_result_set_op_res_gpointer (res, stream, NULL);
>+			g_simple_async_result_set_op_res_gpointer (res, stream, g_object_unref);
> 
> 			goto cleanup;
> 		} else {
>@@ -415,7 +415,7 @@ handle_http_request (GSimpleAsyncResult
> 			uri, request->priv->content_type,
> 			request->priv->content_length, uri_md5));
> 
>-		g_simple_async_result_set_op_res_gpointer (res, stream, NULL);
>+		g_simple_async_result_set_op_res_gpointer (res, stream, g_object_unref);
> 		goto cleanup;
> 	}
> 
>@@ -526,6 +526,8 @@ http_request_send_finish (SoupRequest *r
> 
> 	if (!stream) /* We must always return something */
> 		stream = g_memory_input_stream_new ();
>+	else
>+		g_object_ref (stream);
> 
> 	return stream;
> }
>diff -up evolution-3.8.5/mail/em-folder-tree.c.evo-leaks evolution-3.8.5/mail/em-folder-tree.c
>--- evolution-3.8.5/mail/em-folder-tree.c.evo-leaks	2013-07-23 14:51:50.000000000 +0200
>+++ evolution-3.8.5/mail/em-folder-tree.c	2014-04-09 15:51:31.250060826 +0200
>@@ -3107,6 +3107,8 @@ em_folder_tree_select_next_path (EMFolde
> 		/* TODO : Flags here for better options */
> 		} while (skip_read_folders && unread <=0 &&
> 			gtk_tree_path_compare (current_path, path));
>+
>+		gtk_tree_path_free (current_path);
> 	}
> 
> 	if (path) {
>@@ -3120,6 +3122,8 @@ em_folder_tree_select_next_path (EMFolde
> 			priv->cursor_set = TRUE;
> 		}
> 		gtk_tree_view_scroll_to_cell (tree_view, path, NULL, TRUE, 0.5f, 0.0f);
>+
>+		gtk_tree_path_free (path);
> 	}
> 	return;
> }
>diff -up evolution-3.8.5/modules/itip-formatter/e-mail-formatter-itip.c.evo-leaks evolution-3.8.5/modules/itip-formatter/e-mail-formatter-itip.c
>--- evolution-3.8.5/modules/itip-formatter/e-mail-formatter-itip.c.evo-leaks	2013-07-23 14:51:41.000000000 +0200
>+++ evolution-3.8.5/modules/itip-formatter/e-mail-formatter-itip.c	2014-04-09 15:51:31.251060819 +0200
>@@ -100,6 +100,10 @@ emfe_itip_format (EMailFormatterExtensio
> 				folder, message_uid, "$has_cal", TRUE);
> 		}
> 
>+		g_clear_object (&itip_part->folder);
>+		g_clear_object (&itip_part->msg);
>+		g_free (itip_part->uid);
>+
> 		itip_part->folder = g_object_ref (folder);
> 		itip_part->uid = g_strdup (message_uid);
> 		itip_part->msg = g_object_ref (message);
>diff -up evolution-3.8.5/modules/itip-formatter/e-mail-parser-itip.c.evo-leaks evolution-3.8.5/modules/itip-formatter/e-mail-parser-itip.c
>--- evolution-3.8.5/modules/itip-formatter/e-mail-parser-itip.c.evo-leaks	2013-07-23 14:51:40.000000000 +0200
>+++ evolution-3.8.5/modules/itip-formatter/e-mail-parser-itip.c	2014-04-09 15:51:31.251060819 +0200
>@@ -110,6 +110,9 @@ mail_part_itip_free (EMailPart *mail_par
> 	g_free (pitip->uid);
> 	g_hash_table_destroy (pitip->real_comps);
> 
>+	g_clear_object (&pitip->msg);
>+	g_clear_object (&pitip->folder);
>+
> 	g_clear_object (&pitip->view);
> }
> 
>diff -up evolution-3.8.5/modules/itip-formatter/itip-view.c.evo-leaks evolution-3.8.5/modules/itip-formatter/itip-view.c
>--- evolution-3.8.5/modules/itip-formatter/itip-view.c.evo-leaks	2013-07-23 14:51:41.000000000 +0200
>+++ evolution-3.8.5/modules/itip-formatter/itip-view.c	2014-04-09 15:51:31.252060813 +0200
>@@ -5391,6 +5391,41 @@ extract_itip_data (EMailPartItip *pitip,
> 		return FALSE;
> 	}
> 
>+	if (pitip->comp) {
>+		g_object_unref (pitip->comp);
>+		pitip->comp = NULL;
>+	}
>+
>+	if (pitip->top_level) {
>+		icalcomponent_free (pitip->top_level);
>+		pitip->top_level = NULL;
>+	}
>+
>+	if (pitip->main_comp) {
>+		icalcomponent_free (pitip->main_comp);
>+		pitip->main_comp = NULL;
>+	}
>+	pitip->ical_comp = NULL;
>+
>+	g_free (pitip->calendar_uid);
>+	pitip->calendar_uid = NULL;
>+
>+	g_free (pitip->from_address);
>+	pitip->from_address = NULL;
>+	g_free (pitip->from_name);
>+	pitip->from_name = NULL;
>+	g_free (pitip->to_address);
>+	pitip->to_address = NULL;
>+	g_free (pitip->to_name);
>+	pitip->to_name = NULL;
>+	g_free (pitip->delegator_address);
>+	pitip->delegator_address = NULL;
>+	g_free (pitip->delegator_name);
>+	pitip->delegator_name = NULL;
>+	g_free (pitip->my_address);
>+	pitip->my_address = NULL;
>+	g_hash_table_remove_all (pitip->real_comps);
>+
> 	pitip->top_level = e_cal_util_new_top_level ();
> 
> 	pitip->main_comp = icalparser_parse_string (pitip->vcalendar);
>@@ -5848,6 +5883,7 @@ itip_view_init_view (ItipView *view)
> 	client_cache = e_shell_get_client_cache (shell);
> 	shell_settings = e_shell_get_shell_settings (shell);
> 
>+	g_clear_object (&info->client_cache);
> 	info->client_cache = g_object_ref (client_cache);
> 
>         /* Reset current client before initializing view */

Actions: View | Diff

Attachments on bug 1084414: 882699 | 884542 | 889221 | 889381 | 890503