Attachment 886648 Details for Bug 1088007 – patch fixing messages for clarity

[patch] patch fixing messages for clarity

0001-1088007-Bandwidth-Failure-marked-as-Pass.patch (text/plain), 1.62 KB, created by Greg Nichols on 2014-04-15 20:25:25 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Greg Nichols

Created: 2014-04-15 20:25:25 UTC

Size: 1.62 KB

patch

obsolete

>From d16e3d911032623ea4abf8c74face4b9020a015e Mon Sep 17 00:00:00 2001
>From: Greg Nichols <gnichols@redhat.com>
>Date: Tue, 15 Apr 2014 16:24:31 -0400
>Subject: [PATCH] 1088007 - Bandwidth Failure marked as Pass
>
>---
> hwcert/networkTest.py | 10 +++-------
> 1 file changed, 3 insertions(+), 7 deletions(-)
>
>diff --git a/hwcert/networkTest.py b/hwcert/networkTest.py
>index 3361ce6..c0a700f 100644
>--- a/hwcert/networkTest.py
>+++ b/hwcert/networkTest.py
>@@ -390,7 +390,6 @@ class NetworkTest(Test):
>         messageSize = "1m" # 1 MB
>         bandwidthTarget = 0.8 # 80%
>         cycles = 5
>-        speedErrors = 0
>         for numberOfThreads in [2, 4, 8, 16]:
>             bw_tcp = Command("bw_tcp -P %u -m %s %s" % (numberOfThreads, messageSize, self.getTestServer()))
>             print bw_tcp.command
>@@ -419,13 +418,10 @@ class NetworkTest(Test):
>                 print "Average Bandwidth: %s" % averageBandwidth
>                 return True
>             # otherwise
>-            message = "Warning:"
>-            if self.enforceSpeed:
>-                message = "Error:"
>-                speedErrors += 1
>-            print "%s Average Bandwidth %s Mb/sec is less than %s%% of the interface speed of %s Mb/sec" % (message, averageBandwidth*8, bandwidthTarget*100, self.interfaceSpeed)
>+            print "Warning: Average Bandwidth %s Mb/sec is less than %s%% of the interface speed of %s Mb/sec" % ( averageBandwidth*8, self.bandwidthTarget*100, self.interfaceSpeed)
> 
>-        if speedErrors:
>+        if self.enforceSpeed:
>+            print "Error: Could not achieve required bandwidth"
>             return False
>         return True
> 
>-- 
>1.9.0
>

Actions: View | Diff

Attachments on bug 1088007: 886648