Attachment 888182 Details for Bug 1089583 – 0001-HID-rmi-do-not-handle-touchscreens-through-hid-rmi.patch

[patch] 0001-HID-rmi-do-not-handle-touchscreens-through-hid-rmi.patch

0001-HID-rmi-do-not-handle-touchscreens-through-hid-rmi.patch (text/plain), 1.98 KB, created by Benjamin Tissoires on 2014-04-21 18:12:50 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Benjamin Tissoires

Created: 2014-04-21 18:12:50 UTC

Size: 1.98 KB

patch

obsolete

>From 68f6f9ccfbaf33db29bf8cfb89ff254b971b4661 Mon Sep 17 00:00:00 2001
>From: Benjamin Tissoires <benjamin.tissoires@redhat.com>
>Date: Mon, 21 Apr 2014 11:06:26 -0400
>Subject: [PATCH] HID: rmi: do not handle touchscreens through hid-rmi
>
>Currently, hid-rmi drives every Synaptics product, but the touchscreens
>on the Windows tablets should be handled through hid-multitouch.
>
>Instead of providing a long list of PIDs, rely on the scan_report
>capability to detect which should go to hid-multitouch, and which
>should not go to hid-rmi.
>
>related bug:
>https://bugzilla.kernel.org/show_bug.cgi?id=74241
>https://bugzilla.redhat.com/show_bug.cgi?id=1089583
>
>Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
>---
> drivers/hid/hid-core.c | 13 +++++++++++--
> 1 file changed, 11 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
>index 6ba2fd0..833b0d5 100644
>--- a/drivers/hid/hid-core.c
>+++ b/drivers/hid/hid-core.c
>@@ -776,6 +776,17 @@ static int hid_scan_report(struct hid_device *hid)
> 	    (hid->group == HID_GROUP_MULTITOUCH))
> 		hid->group = HID_GROUP_MULTITOUCH_WIN_8;
> 
>+	/*
>+	* Vendor specific handlings
>+	*/
>+	if ((hid->vendor == USB_VENDOR_ID_SYNAPTICS) &&
>+	    (hid->group == HID_GROUP_GENERIC))
>+		/*
>+		* hid-rmi should take care of them,
>+		* removing HID_GROUP_GENERIC
>+		*/
>+		hid->group = 0;
>+
> 	vfree(parser);
> 	return 0;
> }
>@@ -1840,8 +1851,6 @@ static const struct hid_device_id hid_have_special_driver[] = {
> 	{ HID_USB_DEVICE(USB_VENDOR_ID_SONY, USB_DEVICE_ID_SONY_VAIO_VGP_MOUSE) },
> 	{ HID_USB_DEVICE(USB_VENDOR_ID_STEELSERIES, USB_DEVICE_ID_STEELSERIES_SRWS1) },
> 	{ HID_USB_DEVICE(USB_VENDOR_ID_SUNPLUS, USB_DEVICE_ID_SUNPLUS_WDESKTOP) },
>-	{ HID_USB_DEVICE(USB_VENDOR_ID_SYNAPTICS, HID_ANY_ID) },
>-	{ HID_I2C_DEVICE(USB_VENDOR_ID_SYNAPTICS, HID_ANY_ID) },
> 	{ HID_USB_DEVICE(USB_VENDOR_ID_THINGM, USB_DEVICE_ID_BLINK1) },
> 	{ HID_USB_DEVICE(USB_VENDOR_ID_THRUSTMASTER, 0xb300) },
> 	{ HID_USB_DEVICE(USB_VENDOR_ID_THRUSTMASTER, 0xb304) },
>-- 
>1.9.0
>

Actions: View | Diff

Attachments on bug 1089583: 888182 | 888537 | 888594 | 888596 | 888597 | 888603