Attachment 889303 Details for Bug 1049695 – [PATCH] network: fix the "Firewall Zone" in Identity pane of control-center

[patch] [PATCH] network: fix the "Firewall Zone" in Identity pane of control-center

0001-network-fix-displaying-Firewall-Zone-string-rh-10496.patch (text/plain), 1.45 KB, created by Jirka Klimes on 2014-04-24 14:28:50 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jirka Klimes

Created: 2014-04-24 14:28:50 UTC

Size: 1.45 KB

patch

obsolete

>From 79e4697cad57c40517a2bcbb4ea4380125799312 Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Ji=C5=99=C3=AD=20Klime=C5=A1?= <jklimes@redhat.com>
>Date: Thu, 24 Apr 2014 16:15:29 +0200
>Subject: [PATCH] network: fix displaying "Firewall Zone" string (rh #1049695)
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>The zone has to be allocated to ensure it persist till get get_zones_reply()
>
>https://bugzilla.redhat.com/show_bug.cgi?id=1049695
>Signed-off-by: JiÅÃ KlimeÅ¡ <jklimes@redhat.com>
>---
> panels/network/connection-editor/firewall-helpers.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/panels/network/connection-editor/firewall-helpers.c b/panels/network/connection-editor/firewall-helpers.c
>index cd41a2b..593ce9a 100644
>--- a/panels/network/connection-editor/firewall-helpers.c
>+++ b/panels/network/connection-editor/firewall-helpers.c
>@@ -72,6 +72,7 @@ get_zones_reply (GObject      *source,
>         }
>         gtk_combo_box_set_active (GTK_COMBO_BOX (d->combo), idx);
> 
>+        g_free (d->zone);
>         g_free (d);
> }
> 
>@@ -86,7 +87,7 @@ firewall_ui_setup (NMSettingConnection *setting,
>         bus = g_bus_get_sync (G_BUS_TYPE_SYSTEM, NULL, NULL);
> 
>         d = g_new0 (GetZonesReplyData, 1);
>-        d->zone = nm_setting_connection_get_zone (setting);
>+        d->zone = g_strdup (nm_setting_connection_get_zone (setting));
>         d->combo = combo;
> 
>         g_dbus_connection_call (bus,
>-- 
>1.9.0
>

Actions: View | Diff

Attachments on bug 1049695: 889303