Attachment 890303 Details for Bug 1087734 – fedora-review.txt

fedora-review.txt

review.txt (text/plain), 12.99 KB, created by Shawn Iwinski on 2014-04-28 02:33:48 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Shawn Iwinski

Created: 2014-04-28 02:33:48 UTC

Size: 12.99 KB

patch

obsolete

>Package Review
>==============
>
>Legend:
>[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
>[ ] = Manual review needed
>
>
>
>===== MUST items =====
>
>Generic:
>[x]: Package is licensed with an open-source compatible license and meets
>     other legal requirements as defined in the legal section of Packaging
>     Guidelines.
>[x]: License field in the package spec file matches the actual license.
>     Note: Checking patched sources after %prep for licenses. Licenses found:
>     "Unknown or generated". 361 files have unknown license.
>[x]: Package must own all directories that it creates.
>     Note: Directories without known owners: /etc/horde
>     
>     Owned by dependency php-horde-horde (php-pear(%{pear_channel}/horde))
>     
>[x]: Package does not own files or directories owned by other packages.
>     Note: Dirs in package are owned also by:
>     /usr/share/horde/imp/locale/zh_TW/LC_MESSAGES(imp),
>     /usr/share/horde/imp/locale/zh_CN/LC_MESSAGES(imp),
>     /usr/share/horde/imp/templates/saveimage(imp),
>     /usr/share/horde/imp/templates(imp),
>     /usr/share/horde/imp/templates/rss(imp),
>     /usr/share/horde/imp/lib/Quota(imp),
>     /usr/share/horde/imp/templates/smime(imp), /usr/share/horde/imp/lib(imp),
>     /usr/share/horde/imp/js(imp), /usr/share/horde/imp/templates/prefs(imp),
>     /usr/share/horde/imp/lib/Notification(imp),
>     /usr/share/horde/imp/lib/Crypt(imp),
>     /usr/share/horde/imp/templates/contacts(imp),
>     /usr/share/horde/imp/locale/zh_CN(imp), /usr/share/horde/imp/locale(imp),
>     /usr/share/horde/imp/lib/Block(imp), /usr/share/horde/imp(imp),
>     /etc/horde/imp(imp), /usr/share/horde/imp/templates/thread(imp),
>     /usr/share/horde/imp/themes(imp),
>     /usr/share/horde/imp/templates/search(imp),
>     /usr/share/horde/imp/lib/Sentmail(imp),
>     /usr/share/horde/imp/templates/pgp(imp),
>     /usr/share/horde/imp/locale/zh_TW(imp)
>     
>     Pkg "imp" is being obsoleted by this package
>     
>[!]: Package contains no bundled libraries without FPC exception.
>
>     /usr/share/horde/imp/js/murmurhash3.js = 
>         https://github.com/kazuyukitanimura/murmurhash-js
>
>[x]: Changelog in prescribed format.
>[!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
>     beginning of %install.
>     Note: rm -rf %{buildroot} present but not required
>[x]: Sources contain only permissible code or content.
>[!]: Each %files section contains %defattr if rpm < 4.4
>     Note: %defattr present but not needed
>[-]: Package contains desktop file if it is a GUI application.
>[-]: Development files must be in a -devel package
>[x]: Package uses nothing in %doc for runtime.
>[x]: Package consistently uses macros (instead of hard-coded directory names).
>[x]: Package is named according to the Package Naming Guidelines.
>[x]: Package does not generate any conflict.
>[x]: Package obeys FHS, except libexecdir and /usr/target.
>[-]: If the package is a rename of another package, proper Obsoletes and
>     Provides are present.
>[!]: Requires correct, justified where necessary.
>
>     Per package.xml, update
>         Requires:       php-pear(%{pear_channel}/Horde_Mime) >= 2.0.0
>     to
>         Requires:       php-pear(%{pear_channel}/Horde_Mime) >= 2.1.0
>     
>     
>     Per package.xml, update
>         Requires:       php-pear(%{pear_channel}/Horde_Url) >= 2.0.0
>     to
>         Requires:       php-pear(%{pear_channel}/Horde_Url) >= 2.2.0
>     
>     
>     Per package.xml, add
>         Requires:       php-pear(%{pear_channel}/Horde_Text_Filter_Csstidy) < 3.0.0
>     
>     
>     Update comment
>         # Optional and implicitly required:
>         #     Horde_Vfs, Horde_History, Horde_Http, Horde_Stream_Filter
>     to
>         # Optional and implicitly required:
>         #     Horde_History, Horde_Http
>     
>     
>     Per phpcompatinfo, I do not see "php-ereg" or "php-posix" dependencies.
>
>
>[x]: Spec file is legible and written in American English.
>[-]: Package contains systemd file(s) if in need.
>[x]: Package is not known to require an ExcludeArch tag.
>[x]: Large documentation must go in a -doc subpackage. Large could be size
>     (~1MB) or number of files.
>     Note: Documentation size is 266240 bytes in 9 files.
>[x]: Package complies to the Packaging Guidelines
>[x]: Package successfully compiles and builds into binary rpms on at least one
>     supported primary architecture.
>[x]: Package installs properly.
>[x]: Rpmlint is run on all rpms the build produces.
>     Note: There are rpmlint messages (see attachment).
>[x]: If (and only if) the source package includes the text of the license(s)
>     in its own file, then that file, containing the text of the license(s)
>     for the package is included in %doc.
>[x]: Package requires other packages for directories it uses.
>[x]: All build dependencies are listed in BuildRequires, except for any that
>     are listed in the exceptions section of Packaging Guidelines.
>[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
>[x]: %config files are marked noreplace or the reason is justified.
>[x]: Macros in Summary, %description expandable at SRPM build time.
>[x]: Package does not contain duplicates in %files.
>[x]: Permissions on files are set properly.
>[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
>     work.
>[x]: Package is named using only allowed ASCII characters.
>[x]: No %config files under /usr.
>[x]: Package do not use a name that already exist
>[x]: Package is not relocatable.
>[x]: Sources used to build the package match the upstream source, as provided
>     in the spec URL.
>[x]: Spec file name must match the spec package %{name}, in the format
>     %{name}.spec.
>[x]: File names are valid UTF-8.
>[x]: Packages must not store files under /srv, /opt or /usr/local
>
>===== SHOULD items =====
>
>Generic:
>[!]: Buildroot is not present
>     Note: Buildroot: present but not needed
>[!]: Package has no %clean section with rm -rf %{buildroot} (or
>     $RPM_BUILD_ROOT)
>     Note: %clean present but not required
>[-]: If the source package does not include license text(s) as a separate file
>     from upstream, the packager SHOULD query upstream to include it.
>[x]: Final provides and requires are sane (see attachments).
>[x]: Package functions as described.
>[x]: Latest version is packaged.
>[x]: Package does not include license text files separate from upstream.
>[-]: Description and summary sections in the package spec file contains
>     translations for supported Non-English languages, if available.
>[x]: Package should compile and build into binary rpms on all supported
>     architectures.
>[x]: %check is present and all tests pass.
>[x]: Packages should try to preserve timestamps of original installed files.
>[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
>[x]: Sources can be downloaded from URI in Source: tag
>[x]: Reviewer should test that the package builds in mock.
>[x]: Dist tag is present (not strictly required in GL).
>[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
>[x]: SourceX is a working URL.
>[x]: Spec use %global instead of %define unless justified.
>
>===== EXTRA items =====
>
>Generic:
>[x]: Rpmlint is run on all installed packages.
>     Note: There are rpmlint messages (see attachment).
>[x]: Spec file according to URL is the same as in SRPM.
>
>PHP:
>[x]: Run phpci static analyze on all php files.
>
>
>
>Rpmlint
>-------
>Checking: php-horde-imp-6.1.7-1.fc21.noarch.rpm
>          php-horde-imp-6.1.7-1.fc21.src.rpm
>php-horde-imp.noarch: W: spelling-error Summary(en_US) webmail -> web mail, web-mail, webmaster
>php-horde-imp.noarch: W: spelling-error %description -l en_US webmail -> web mail, web-mail, webmaster
>php-horde-imp.noarch: W: conffile-without-noreplace-flag /etc/horde/imp/hooks.php.dist
>php-horde-imp.noarch: W: conffile-without-noreplace-flag /etc/horde/imp/menu.php.dist
>php-horde-imp.noarch: W: conffile-without-noreplace-flag /etc/horde/imp/conf.xml
>php-horde-imp.noarch: E: non-readable /etc/horde/imp/hooks.php.dist 0640L
>php-horde-imp.noarch: E: non-readable /etc/horde/imp/menu.php.dist 0640L
>php-horde-imp.noarch: E: non-standard-dir-perm /etc/horde/imp 0770L
>php-horde-imp.noarch: E: non-readable /etc/horde/imp/prefs.php 0660L
>php-horde-imp.noarch: E: non-readable /etc/horde/imp/mime_drivers.php 0660L
>php-horde-imp.noarch: E: non-readable /etc/horde/imp/conf.xml 0660L
>php-horde-imp.noarch: E: non-readable /etc/horde/imp/backends.php 0660L
>php-horde-imp.noarch: W: no-manual-page-for-binary imp-bounce-spam
>php-horde-imp.noarch: W: no-manual-page-for-binary imp-mailbox-decode
>php-horde-imp.noarch: W: no-manual-page-for-binary imp-query-imap-cache
>php-horde-imp.noarch: W: no-manual-page-for-binary imp-admin-upgrade
>php-horde-imp.noarch: W: install-file-in-docs /usr/share/doc/pear/imp/INSTALL
>php-horde-imp.src: W: spelling-error Summary(en_US) webmail -> web mail, web-mail, webmaster
>php-horde-imp.src: W: spelling-error %description -l en_US webmail -> web mail, web-mail, webmaster
>2 packages and 0 specfiles checked; 7 errors, 12 warnings.
>
>
>
>
>Rpmlint (installed packages)
>----------------------------
># rpmlint php-horde-imp
>php-horde-imp.noarch: W: spelling-error Summary(en_US) webmail -> web mail, web-mail, webmaster
>php-horde-imp.noarch: W: spelling-error %description -l en_US webmail -> web mail, web-mail, webmaster
>php-horde-imp.noarch: W: conffile-without-noreplace-flag /etc/horde/imp/hooks.php.dist
>php-horde-imp.noarch: W: conffile-without-noreplace-flag /etc/horde/imp/menu.php.dist
>php-horde-imp.noarch: W: conffile-without-noreplace-flag /etc/horde/imp/conf.xml
>php-horde-imp.noarch: E: non-readable /etc/horde/imp/hooks.php.dist 0640L
>php-horde-imp.noarch: E: non-readable /etc/horde/imp/menu.php.dist 0640L
>php-horde-imp.noarch: E: non-standard-dir-perm /etc/horde/imp 0770L
>php-horde-imp.noarch: E: non-readable /etc/horde/imp/prefs.php 0660L
>php-horde-imp.noarch: E: non-readable /etc/horde/imp/mime_drivers.php 0660L
>php-horde-imp.noarch: E: non-readable /etc/horde/imp/conf.xml 0660L
>php-horde-imp.noarch: E: non-readable /etc/horde/imp/backends.php 0660L
>php-horde-imp.noarch: W: no-manual-page-for-binary imp-bounce-spam
>php-horde-imp.noarch: W: no-manual-page-for-binary imp-mailbox-decode
>php-horde-imp.noarch: W: no-manual-page-for-binary imp-query-imap-cache
>php-horde-imp.noarch: W: no-manual-page-for-binary imp-admin-upgrade
>php-horde-imp.noarch: W: install-file-in-docs /usr/share/doc/pear/imp/INSTALL
>1 packages and 0 specfiles checked; 7 errors, 10 warnings.
># echo 'rpmlint-done:'
>
>
>
>Requires
>--------
>php-horde-imp (rpmlib, GLIBC filtered):
>    /bin/sh
>    /usr/bin/env
>    /usr/bin/pear
>    /usr/bin/php
>    config(php-horde-imp)
>    httpd
>    mod_php
>    php(language)
>    php-channel(pear.horde.org)
>    php-date
>    php-dom
>    php-ereg
>    php-filter
>    php-gettext
>    php-hash
>    php-json
>    php-openssl
>    php-pcre
>    php-pear(PEAR)
>    php-pear(pear.horde.org/Horde_Auth)
>    php-pear(pear.horde.org/Horde_Browser)
>    php-pear(pear.horde.org/Horde_Cache)
>    php-pear(pear.horde.org/Horde_Compress)
>    php-pear(pear.horde.org/Horde_Core)
>    php-pear(pear.horde.org/Horde_Crypt)
>    php-pear(pear.horde.org/Horde_Css_Parser)
>    php-pear(pear.horde.org/Horde_Date)
>    php-pear(pear.horde.org/Horde_Editor)
>    php-pear(pear.horde.org/Horde_Exception)
>    php-pear(pear.horde.org/Horde_Icalendar)
>    php-pear(pear.horde.org/Horde_Image)
>    php-pear(pear.horde.org/Horde_Imap_Client)
>    php-pear(pear.horde.org/Horde_Itip)
>    php-pear(pear.horde.org/Horde_ListHeaders)
>    php-pear(pear.horde.org/Horde_LoginTasks)
>    php-pear(pear.horde.org/Horde_Mail)
>    php-pear(pear.horde.org/Horde_Mime)
>    php-pear(pear.horde.org/Horde_Mime_Viewer)
>    php-pear(pear.horde.org/Horde_Nls)
>    php-pear(pear.horde.org/Horde_Notification)
>    php-pear(pear.horde.org/Horde_Perms)
>    php-pear(pear.horde.org/Horde_Role)
>    php-pear(pear.horde.org/Horde_Serialize)
>    php-pear(pear.horde.org/Horde_SpellChecker)
>    php-pear(pear.horde.org/Horde_Stream)
>    php-pear(pear.horde.org/Horde_Stream_Filter)
>    php-pear(pear.horde.org/Horde_Support)
>    php-pear(pear.horde.org/Horde_Text_Filter)
>    php-pear(pear.horde.org/Horde_Text_Filter_Csstidy)
>    php-pear(pear.horde.org/Horde_Text_Flowed)
>    php-pear(pear.horde.org/Horde_Token)
>    php-pear(pear.horde.org/Horde_Tree)
>    php-pear(pear.horde.org/Horde_Url)
>    php-pear(pear.horde.org/Horde_Util)
>    php-pear(pear.horde.org/Horde_Vfs)
>    php-pear(pear.horde.org/Horde_View)
>    php-pear(pear.horde.org/horde)
>    php-posix
>    php-spl
>
>
>
>Provides
>--------
>php-horde-imp:
>    config(php-horde-imp)
>    imp
>    php-horde-imp
>    php-pear(pear.horde.org/imp)
>
>
>
>Source checksums
>----------------
>http://pear.horde.org/get/imp-6.1.7.tgz :
>  CHECKSUM(SHA256) this package     : 1be1c88bdb8abf8b5b340160523d372e7124bcd442e2d7c049ea83a97e70bb20
>  CHECKSUM(SHA256) upstream package : 1be1c88bdb8abf8b5b340160523d372e7124bcd442e2d7c049ea83a97e70bb20
>
>
>Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13
>Command line :/usr/bin/fedora-review --mock-config fedora-rawhide-x86_64 -b 1087734
>Buildroot used: fedora-rawhide-x86_64
>Active plugins: Generic, PHP, Shell-api
>Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, Ruby
>Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG

Actions: View

Attachments on bug 1087734: 890302 | 890303