Attachment 890741 Details for Bug 1092015 – Prpoposed fix

[patch] Prpoposed fix

0001-normalize-name-as-a-byte-string.patch (text/plain), 1.36 KB, created by Petr Pisar on 2014-04-29 10:50:48 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Petr Pisar

Created: 2014-04-29 10:50:48 UTC

Size: 1.36 KB

patch

obsolete

>From f3fb6a261e047ca7068b08c0c292ae22d9007656 Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Petr=20P=C3=ADsa=C5=99?= <ppisar@redhat.com>
>Date: Tue, 29 Apr 2014 12:37:39 +0200
>Subject: [PATCH] normalize name as a byte string
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>Since Encode-2.53, Encode::decode_utf8() requires argument to be
>a byte string. Because URI::Escape::uri_unescape() returns unicode
>string on unicode string input, one need to convert it to a byte
>string before.
>
><https://github.com/mojomojo/mojomojo/issues/121#issuecomment-41651507>
>
>Signed-off-by: Petr PÃsaÅ <ppisar@redhat.com>
>---
> lib/MojoMojo/Schema/ResultSet/Page.pm | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/lib/MojoMojo/Schema/ResultSet/Page.pm b/lib/MojoMojo/Schema/ResultSet/Page.pm
>index 306aa6a..3f1a7e2 100644
>--- a/lib/MojoMojo/Schema/ResultSet/Page.pm
>+++ b/lib/MojoMojo/Schema/ResultSet/Page.pm
>@@ -177,8 +177,8 @@ sub normalize_name {
>     $name =~ s/\s+/_/g;
>     $name = lc($name);
>     return (
>-        Encode::decode_utf8(URI::Escape::uri_unescape($name_orig)),
>-        Encode::decode_utf8(URI::Escape::uri_unescape($name)),
>+        Encode::decode_utf8(URI::Escape::uri_unescape(Encode::encode_utf8($name_orig))),
>+        Encode::decode_utf8(URI::Escape::uri_unescape(Encode::encode_utf8($name))),
>     );
> }
> 
>-- 
>1.9.0
>

Actions: View | Diff

Attachments on bug 1092015: 890741