Attachment 893775 Details for Bug 1095915 – Patch to fix the problem

[patch] Patch to fix the problem

0001-Apply-upstream-patch-to-fix-memory-leak-on-machines-.patch (text/plain), 2.41 KB, created by Dr. Tilmann Bubeck on 2014-05-08 20:04:09 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Dr. Tilmann Bubeck

Created: 2014-05-08 20:04:09 UTC

Size: 2.41 KB

patch

obsolete

>From 211f4b7f6cac883e9578bab852b3b9bf3dcf0375 Mon Sep 17 00:00:00 2001
>From: "Dr. Tilmann Bubeck" <tilmann@bubecks.de>
>Date: Thu, 8 May 2014 21:57:01 +0200
>Subject: [PATCH] Apply upstream patch to fix memory leak on machines without a
> PCI bus
>
>This applies the upstream patch found at https://github.com/Irqbalance/irqbalance/commit/699deffdd881bf4759f3fcc4d6ee3e018e4c266e
>
>If a system has no pci devices the opening of the pci bus directory in
>rebuild_irq_db will fail, leading to a memory leak.  Fix it by freeing the list
>we create in that function always on exit
>
>Signed-off-by: Dr. Tilmann Bubeck <tilmann@bubecks.de>
>---
> irqbalance-fix-memory-leak-in-classify-code.patch | 21 +++++++++++++++++++++
> irqbalance.spec                                   |  6 +++++-
> 2 files changed, 26 insertions(+), 1 deletion(-)
> create mode 100644 irqbalance-fix-memory-leak-in-classify-code.patch
>
>diff --git a/irqbalance-fix-memory-leak-in-classify-code.patch b/irqbalance-fix-memory-leak-in-classify-code.patch
>new file mode 100644
>index 0000000..212cc21
>--- /dev/null
>+++ b/irqbalance-fix-memory-leak-in-classify-code.patch
>@@ -0,0 +1,21 @@
>+diff --git a/classify.c b/classify.c
>+index 1867a94..94b53b8 100644
>+--- a/classify.c
>++++ b/classify.c
>+@@ -465,7 +465,7 @@ void rebuild_irq_db(void)
>+ 
>+ 	devdir = opendir(SYSDEV_DIR);
>+ 	if (!devdir)
>+-		return;
>++		goto free;
>+ 
>+ 	do {
>+ 		entry = readdir(devdir);
>+@@ -482,6 +482,7 @@ void rebuild_irq_db(void)
>+ 
>+ 	for_each_irq(tmp_irqs, add_missing_irq, NULL);
>+ 
>++free:
>+ 	g_list_free_full(tmp_irqs, free);
>+ 
>+ }
>diff --git a/irqbalance.spec b/irqbalance.spec
>index 6a5cdbf..996321f 100644
>--- a/irqbalance.spec
>+++ b/irqbalance.spec
>@@ -1,6 +1,6 @@
> Name:           irqbalance
> Version:        1.0.7
>-Release:        4%{?dist}
>+Release:        5%{?dist}
> Epoch:          2
> Summary:        IRQ balancing daemon
> 
>@@ -23,6 +23,7 @@ Requires: numactl-libs
> ExclusiveArch: %{ix86} x86_64 ia64 ppc ppc64 ppc64le %{arm}
> 
> Patch1: irqbalance-1.0.4-env-file-path.patch
>+Patch2: irqbalance-fix-memory-leak-in-classify-code.patch
> 
> %description
> irqbalance is a daemon that evenly distributes IRQ load across
>@@ -68,6 +69,9 @@ fi
> /sbin/chkconfig --del irqbalance >/dev/null 2>&1 || :
> 
> %changelog
>+* Thu May 08 2014 Dr. Tilmann bubeck <tilmann@bubecks.de> - 2:1.0.7-5
>+- fix memory leak in classify code
>+
> * Mon Feb 10 2014 Petr Holasek <pholasek@redhat.com> - 2:1.0.7-4
> - Missing autogen.sh call fixed
> 
>-- 
>1.9.0
>

Actions: View | Diff

Attachments on bug 1095915: 893775