Attachment 894017 Details for Bug 1096185 – Do not expand the mountpoint path

[patch] Do not expand the mountpoint path

0001-Do-not-expand-the-mountpoint-path.patch (text/plain), 1.18 KB, created by Vít Ondruch on 2014-05-09 11:37:13 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Vít Ondruch

Created: 2014-05-09 11:37:13 UTC

Size: 1.18 KB

patch

obsolete

>From 6edc56750fb53b08dfbef5774f1e8f15f71a8d0a Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?V=C3=ADt=20Ondruch?= <vondruch@redhat.com>
>Date: Fri, 9 May 2014 13:28:45 +0200
>Subject: [PATCH] Do not expand the mountpoint path.
>
>Stating the mount point might cause deadlocks, when mount is not working
>as expected. This might be case for NFS mounts after change of computer
>location.
>---
> py/mockbuild/backend.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/py/mockbuild/backend.py b/py/mockbuild/backend.py
>index f8df77d..0ff784f 100644
>--- a/py/mockbuild/backend.py
>+++ b/py/mockbuild/backend.py
>@@ -939,7 +939,7 @@ class Root(object):
>         # may prevent clean unmount.
>         for mountline in reversed(mountpoints):
>             mountpoint = mountline.split()[1]
>-            if os.path.realpath(mountpoint).startswith(os.path.realpath(self.makeChrootPath()) + "/"):
>+            if mountpoint.startswith(os.path.realpath(self.makeChrootPath()) + "/"):
>                 cmd = "umount -n -l %s" % mountpoint
>                 self.root_log.warning("Forcibly unmounting '%s' from chroot." % mountpoint)
>                 mockbuild.util.do(cmd, raiseExc=0, shell=True, env=self.env)
>-- 
>1.9.0
>

Actions: View | Diff

Attachments on bug 1096185: 894017