Attachment 895520 Details for Bug 1094864 – review.txt

review.txt

review.txt (text/plain), 7.48 KB, created by Remi Collet on 2014-05-14 15:19:44 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Remi Collet

Created: 2014-05-14 15:19:44 UTC

Size: 7.48 KB

patch

obsolete

>Package Review
>==============
>
>Legend:
>[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
>[ ] = Manual review needed
>
>[!]: Development files must be in a -devel package
>  Not provided on packager choice.
>  Could be add later.
>
>[!]: Package must own all directories that it creates.
>   Must own /usr/share/doc/pecl/xmldiff
>
>===== MUST items =====
>
>C/C++:
>[x]: Package does not contain kernel modules.
>[x]: Package contains no static executables.
>[x]: Development (unversioned) .so files in -devel subpackage, if present.
>     Note: Unversioned so-files in private %_libdir subdirectory (see
>     attachment). Verify they are not in ld path.
>[x]: Package does not contain any libtool archives (.la)
>[x]: Rpath absent or only used for internal libs.
>
>Generic:
>[x]: Package is licensed with an open-source compatible license and meets
>     other legal requirements as defined in the legal section of Packaging
>     Guidelines.
>[x]: License field in the package spec file matches the actual license.
>     Note: Checking patched sources after %prep for licenses. Licenses found:
>     "BSD (2 clause)". Detailed output of licensecheck in
>     /home/extras/SPECS/review/1094864-php-pecl-xmldiff/licensecheck.txt
>[x]: %build honors applicable compiler flags or justifies otherwise.
>[x]: Package contains no bundled libraries without FPC exception.
>[x]: Changelog in prescribed format.
>[x]: Sources contain only permissible code or content.
>[-]: Package contains desktop file if it is a GUI application.
>[!]: Development files must be in a -devel package
>[x]: Package uses nothing in %doc for runtime.
>[x]: Package consistently uses macros (instead of hard-coded directory names).
>[x]: Package is named according to the Package Naming Guidelines.
>[x]: Package does not generate any conflict.
>[x]: Package obeys FHS, except libexecdir and /usr/target.
>[-]: If the package is a rename of another package, proper Obsoletes and
>     Provides are present.
>[x]: Requires correct, justified where necessary.
>[x]: Spec file is legible and written in American English.
>[-]: Package contains systemd file(s) if in need.
>[x]: Useful -debuginfo package or justification otherwise.
>[x]: Package is not known to require an ExcludeArch tag.
>[-]: Large documentation must go in a -doc subpackage. Large could be size
>     (~1MB) or number of files.
>     Note: Documentation size is 10240 bytes in 2 files.
>[x]: Package complies to the Packaging Guidelines
>[x]: Package successfully compiles and builds into binary rpms on at least one
>     supported primary architecture.
>[x]: Package installs properly.
>[x]: Rpmlint is run on all rpms the build produces.
>     Note: No rpmlint messages.
>[x]: If (and only if) the source package includes the text of the license(s)
>     in its own file, then that file, containing the text of the license(s)
>     for the package is included in %doc.
>[x]: Package requires other packages for directories it uses.
>[!]: Package must own all directories that it creates.
>[x]: Package does not own files or directories owned by other packages.
>[x]: All build dependencies are listed in BuildRequires, except for any that
>     are listed in the exceptions section of Packaging Guidelines.
>[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
>[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
>     beginning of %install.
>[x]: %config files are marked noreplace or the reason is justified.
>[x]: Macros in Summary, %description expandable at SRPM build time.
>[x]: Package does not contain duplicates in %files.
>[x]: Permissions on files are set properly.
>[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
>     work.
>[x]: Package is named using only allowed ASCII characters.
>[x]: No %config files under /usr.
>[x]: Package do not use a name that already exist
>[x]: Package is not relocatable.
>[x]: Sources used to build the package match the upstream source, as provided
>     in the spec URL.
>[x]: Spec file name must match the spec package %{name}, in the format
>     %{name}.spec.
>[x]: File names are valid UTF-8.
>[x]: Packages must not store files under /srv, /opt or /usr/local
>
>===== SHOULD items =====
>
>Generic:
>[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
>[-]: If the source package does not include license text(s) as a separate file
>     from upstream, the packager SHOULD query upstream to include it.
>[x]: Final provides and requires are sane (see attachments).
>[x]: Package functions as described.
>[x]: Latest version is packaged.
>[x]: Package does not include license text files separate from upstream.
>[-]: Description and summary sections in the package spec file contains
>     translations for supported Non-English languages, if available.
>[x]: Package should compile and build into binary rpms on all supported
>     architectures.
>[x]: %check is present and all tests pass.
>[x]: Packages should try to preserve timestamps of original installed files.
>[x]: Sources can be downloaded from URI in Source: tag
>[x]: Reviewer should test that the package builds in mock.
>[x]: Buildroot is not present
>[x]: Package has no %clean section with rm -rf %{buildroot} (or
>     $RPM_BUILD_ROOT)
>[x]: Dist tag is present (not strictly required in GL).
>[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
>[x]: Uses parallel make %{?_smp_mflags} macro.
>[x]: SourceX is a working URL.
>[x]: Spec use %global instead of %define unless justified.
>
>===== EXTRA items =====
>
>Generic:
>[x]: Rpmlint is run on all installed packages.
>     Note: No rpmlint messages.
>[x]: Large data in /usr/share should live in a noarch subpackage if package is
>     arched.
>[x]: Spec file according to URL is the same as in SRPM.
>
>PHP:
>[x]: Run phpci static analyze on all php files.
>     Note: phpCompatInfo version 3.1.0 static analyze results in
>     /home/extras/SPECS/review/1094864-php-pecl-xmldiff/phpci.log
>
>
>Rpmlint
>-------
>Checking: php-pecl-xmldiff-0.9.2-3.fc20.x86_64.rpm
>          php-pecl-xmldiff-0.9.2-3.fc20.src.rpm
>2 packages and 0 specfiles checked; 0 errors, 0 warnings.
>
>
>
>
>Rpmlint (installed packages)
>----------------------------
># rpmlint php-pecl-xmldiff
>1 packages and 0 specfiles checked; 0 errors, 0 warnings.
># echo 'rpmlint-done:'
>
>
>
>Requires
>--------
>php-pecl-xmldiff (rpmlib, GLIBC filtered):
>    /bin/sh
>    /usr/bin/pecl
>    config(php-pecl-xmldiff)
>    libc.so.6()(64bit)
>    libdiffmark.so.1()(64bit)
>    libdl.so.2()(64bit)
>    libgcc_s.so.1()(64bit)
>    libgcc_s.so.1(GCC_3.0)(64bit)
>    libm.so.6()(64bit)
>    libstdc++.so.6()(64bit)
>    libstdc++.so.6(CXXABI_1.3)(64bit)
>    libxml2.so.2()(64bit)
>    libxml2.so.2(LIBXML2_2.4.30)(64bit)
>    libz.so.1()(64bit)
>    php(api)
>    php(zend-abi)
>    php-dom(x86-64)
>    php-libxml(x86-64)
>    php-xml
>    rtld(GNU_HASH)
>
>
>
>Provides
>--------
>php-pecl-xmldiff:
>    config(php-pecl-xmldiff)
>    php-pecl-xmldiff
>    php-pecl-xmldiff(x86-64)
>    php-xmldiff
>    php-xmldiff(x86-64)
>
>
>
>Unversioned so-files
>--------------------
>php-pecl-xmldiff: /usr/lib64/php/modules/xmldiff.so
>
>Source checksums
>----------------
>http://pecl.php.net/get/xmldiff-0.9.2.tgz :
>  CHECKSUM(SHA256) this package     : 60d7d7fde2ebb695ae2cb26803153ad07a6146e0d70c102b3403131c86177550
>  CHECKSUM(SHA256) upstream package : 60d7d7fde2ebb695ae2cb26803153ad07a6146e0d70c102b3403131c86177550
>
>
>Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13
>Command line :/usr/bin/fedora-review -b 1094864
>Buildroot used: fedora-20-x86_64
>Active plugins: Generic, PHP, Shell-api, C/C++
>Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, Ruby
>Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG

Actions: View

Attachments on bug 1094864: 895520