Attachment 896781 Details for Bug 1098787 – patch

[patch] patch

0001-cli-Error-out-when-XML-output-isn-t-supported.patch (text/plain), 977 bytes, created by Peter Krempa on 2014-05-18 14:58:50 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Peter Krempa

Created: 2014-05-18 14:58:50 UTC

Size: 977 bytes

patch

obsolete

>From 34c6a3dcc6b88f94bcb1058f7b8db222d3ee78f0 Mon Sep 17 00:00:00 2001
>Message-Id: <34c6a3dcc6b88f94bcb1058f7b8db222d3ee78f0.1400425086.git.pkrempa@redhat.com>
>From: Peter Krempa <pkrempa@redhat.com>
>Date: Sun, 18 May 2014 16:56:58 +0200
>Subject: [PATCH] cli: Error out when XML output isn't supported
>
>Return failure instead of silently returning human readable output.
>
>Signed-off-by: Peter Krempa <pkrempa@redhat.com>
>---
> cli/src/cli.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/cli/src/cli.c b/cli/src/cli.c
>index 67f1ad2..8d54b52 100644
>--- a/cli/src/cli.c
>+++ b/cli/src/cli.c
>@@ -321,7 +321,8 @@ cli_opt_parse (char *opt, struct cli_state *state)
> #if (HAVE_LIB_XML)
>                 state->mode |= GLUSTER_MODE_XML;
> #else
>-                cli_err ("XML output not supported. Ignoring '--xml' option");
>+                cli_err ("XML output not supported.");
>+                exit(1);
> #endif
>                 return 0;
>         }
>-- 
>1.9.3
>

Actions: View | Diff

Attachments on bug 1098787: 896781