Attachment 902122 Details for Bug 1104597 – [PATCH] ssl: require server name to match in ssl_LookupSID()

[patch] [PATCH] ssl: require server name to match in ssl_LookupSID()

0001-ssl-require-server-name-to-match-in-ssl_LookupSID.patch (text/plain), 997 bytes, created by Kamil Dudka on 2014-06-04 10:05:21 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kamil Dudka

Created: 2014-06-04 10:05:21 UTC

Size: 997 bytes

patch

obsolete

>From aa1eed18d6d9e2c3f789f6e3aa92298e3577731a Mon Sep 17 00:00:00 2001
>From: Kamil Dudka <kdudka@redhat.com>
>Date: Wed, 4 Jun 2014 11:56:52 +0200
>Subject: [PATCH] ssl: require server name to match in ssl_LookupSID()
>
>... for a session cache entry to be picked
>---
> nss/lib/ssl/sslnonce.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
>diff --git a/nss/lib/ssl/sslnonce.c b/nss/lib/ssl/sslnonce.c
>index 2e861f1..ee521a2 100644
>--- a/nss/lib/ssl/sslnonce.c
>+++ b/nss/lib/ssl/sslnonce.c
>@@ -284,9 +284,7 @@ ssl_LookupSID(const PRIPv6Addr *addr, PRUint16 port, const char *peerID,
> 		    sid->u.ssl3.keys.resumable) &&
> 		   /* server hostname matches. */
> 	           (sid->urlSvrName != NULL) &&
>-		   ((0 == PORT_Strcmp(urlSvrName, sid->urlSvrName)) ||
>-		    ((sid->peerCert != NULL) && (SECSuccess == 
>-		      CERT_VerifyCertName(sid->peerCert, urlSvrName))) )
>+		   (0 == PORT_Strcmp(urlSvrName, sid->urlSvrName))
> 		  ) {
> 	    /* Hit */
> 	    sid->lastAccessTime = now;
>-- 
>1.9.3
>

Actions: View | Diff

Attachments on bug 1104597: 902122