Attachment 907961 Details for Bug 1059607 – Free object allocated at quorum_register_callback

[patch] Free object allocated at quorum_register_callback

tmp.l4L3g0jEGv (text/plain), 1.02 KB, created by Jan Friesse on 2014-06-12 07:03:13 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jan Friesse

Created: 2014-06-12 07:03:13 UTC

Size: 1.02 KB

patch

obsolete

>From fa71067a93ea99d8dc4812e3a028ae154216a91a Mon Sep 17 00:00:00 2001
>From: Masatake YAMATO <yamato@redhat.com>
>Date: Sat, 18 Jan 2014 03:18:51 +0000
>Subject: [PATCH] Free object allocated at quorum_register_callback
>
>Memory object allocated with malloc at quorum_register_callback
>is not freed. The object is linked to internal_trackers_list.
>
>The object is unlinked at quorum_unregister_callback. However,
>it is not freed at the function.
>
>Signed-off-by: Masatake YAMATO <yamato@redhat.com>
>Reviewed-by: Jan Friesse <jfriesse@redhat.com>
>---
> exec/vsf_quorum.c |    1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
>diff --git a/exec/vsf_quorum.c b/exec/vsf_quorum.c
>index 7a20a45..2a3a263 100644
>--- a/exec/vsf_quorum.c
>+++ b/exec/vsf_quorum.c
>@@ -238,6 +238,7 @@ static int quorum_unregister_callback(quorum_callback_fn_t function, void *conte
> 		pd = list_entry(tmp, struct internal_callback_pd, list);
> 		if (pd->callback == function && pd->context == context) {
> 			list_del(&pd->list);
>+			free(pd);
> 			return 0;
> 		}
> 	}
>-- 
>1.7.1
>

Actions: View | Diff

Attachments on bug 1059607: 907961 | 907962 | 907986