Attachment 907968 Details for Bug 1108508 – totemsrp: Fix typo with cont gather

[patch] totemsrp: Fix typo with cont gather

tmp.GbgkstFA83 (text/plain), 1.13 KB, created by Jan Friesse on 2014-06-12 07:27:40 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jan Friesse

Created: 2014-06-12 07:27:40 UTC

Size: 1.13 KB

patch

obsolete

>From 38c04d9a66ba41dae14a57eba119dabb31cbb18f Mon Sep 17 00:00:00 2001
>From: Jan Friesse <jfriesse@redhat.com>
>Date: Thu, 23 Jan 2014 17:32:11 +0100
>Subject: [PATCH] totemsrp: Fix typo with cont gather
>
>Patch f3ffd3da5c71a10e1783a38e50bafc61192854f6 introduced named states
>of state-machine, but sadly contains logical problem causing
>stats.continuous_gather increasing even when it shouldn't. Problem is
>not critical, because continuous_gather is set to 0 on successful
>membership creation.
>
>Signed-off-by: Jan Friesse <jfriesse@redhat.com>
>Reviewed-by: Christine Caulfield <ccaulfie@redhat.com>
>---
> exec/totemsrp.c |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/exec/totemsrp.c b/exec/totemsrp.c
>index a1397d1..5f5b7be 100644
>--- a/exec/totemsrp.c
>+++ b/exec/totemsrp.c
>@@ -2089,7 +2089,7 @@ static void memb_state_gather_enter (
> 	instance->memb_state = MEMB_STATE_GATHER;
> 	instance->stats.gather_entered++;
> 
>-	if (TOTEMSRP_GSFROM_THE_CONSENSUS_TIMEOUT_EXPIRED == 3) {
>+	if (gather_from == TOTEMSRP_GSFROM_THE_CONSENSUS_TIMEOUT_EXPIRED) {
> 		/*
> 		 * State 3 means gather, so we are continuously gathering.
> 		 */
>-- 
>1.7.1
>

Actions: View | Diff

Attachments on bug 1108508: 907968