Attachment 907986 Details for Bug 1059607 – votequorum: Properly initialize atb and atb_string

[patch] votequorum: Properly initialize atb and atb_string

tmp.2oZOOMdXbf (text/plain), 1.01 KB, created by Jan Friesse on 2014-06-12 07:36:12 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jan Friesse

Created: 2014-06-12 07:36:12 UTC

Size: 1.01 KB

patch

obsolete

>From e1801ba49738a3ae2ba3ca08c2b74dda5ff9056c Mon Sep 17 00:00:00 2001
>From: Jan Friesse <jfriesse@redhat.com>
>Date: Wed, 26 Feb 2014 13:01:09 +0100
>Subject: [PATCH] votequorum: Properly initialize atb and atb_string
>
>icmap_get_* behavior is to NOT modify passed variable when it doesn't
>success. So we must initialize variable before icmap_get_* call.
>
>Signed-off-by: Jan Friesse <jfriesse@redhat.com>
>Reviewed-by: Fabio M. Di Nitto <fdinitto@redhat.com>
>---
> exec/votequorum.c |    4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/exec/votequorum.c b/exec/votequorum.c
>index dc0999d..1e913eb 100644
>--- a/exec/votequorum.c
>+++ b/exec/votequorum.c
>@@ -1211,9 +1211,9 @@ static char *votequorum_readconfig(int runtime)
> 	uint32_t node_votes = 0, qdevice_votes = 0;
> 	uint32_t node_expected_votes = 0, expected_votes = 0;
> 	uint32_t node_count = 0;
>-	uint8_t atb;
>+	uint8_t atb = 0;
> 	int have_nodelist, have_qdevice;
>-	char *atb_string;
>+	char *atb_string = NULL;
> 	char *error = NULL;
> 
> 	ENTER();
>-- 
>1.7.1
>

Actions: View | Diff

Attachments on bug 1059607: 907961 | 907962 | 907986