Attachment 907987 Details for Bug 1078361 – config: Handle totem_set_volatile_defaults errors

[patch] config: Handle totem_set_volatile_defaults errors

tmp.4j7lVRC5Qq (text/plain), 1.05 KB, created by Jan Friesse on 2014-06-12 07:39:14 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jan Friesse

Created: 2014-06-12 07:39:14 UTC

Size: 1.05 KB

patch

obsolete

>From 2f0cad20a9a368683fd59a869b2cb360bd31f95b Mon Sep 17 00:00:00 2001
>From: Jan Friesse <jfriesse@redhat.com>
>Date: Wed, 12 Mar 2014 12:59:30 +0100
>Subject: [PATCH] config: Handle totem_set_volatile_defaults errors
>
>When totem_set_volatile_defaults is called from totem_config_validate
>return code is unchecked.
>
>It's then perfectly possible to set (for example) join timeout to very
>small value (1) and consensus value is then set to 0 making corosync
>unable to create membership.
>
>Signed-off-by: Jan Friesse <jfriesse@redhat.com>
>Reviewed-by: Christine Caulfield <ccaulfie@redhat.com>
>---
> exec/totemconfig.c |    4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
>diff --git a/exec/totemconfig.c b/exec/totemconfig.c
>index c17c673..7180646 100644
>--- a/exec/totemconfig.c
>+++ b/exec/totemconfig.c
>@@ -1007,7 +1007,9 @@ int totem_config_validate (
> 		goto parse_error;
> 	}
> 
>-	totem_set_volatile_defaults(totem_config, error_string);
>+	if (totem_set_volatile_defaults(totem_config, error_string) == -1) {
>+		return (-1);
>+	}
> 
> 	/*
> 	 * RRP values validation
>-- 
>1.7.1
>

Actions: View | Diff

Attachments on bug 1078361: 907987 | 907988 | 907989 | 907990 | 907991 | 907992 | 907993 | 946428 | 946429 | 946430