Attachment 908000 Details for Bug 1108525 – logsys: Log error if blackbox cannot be created

[patch] logsys: Log error if blackbox cannot be created

tmp.sd6FULiGT0 (text/plain), 1.23 KB, created by Jan Friesse on 2014-06-12 08:02:59 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jan Friesse

Created: 2014-06-12 08:02:59 UTC

Size: 1.23 KB

patch

obsolete

>From 19c5b63ff5fae43c2acf28ce95cca6460f500176 Mon Sep 17 00:00:00 2001
>From: Jan Friesse <jfriesse@redhat.com>
>Date: Tue, 27 May 2014 17:26:32 +0200
>Subject: [PATCH] logsys: Log error if blackbox cannot be created
>
>Signed-off-by: Jan Friesse <jfriesse@redhat.com>
>Reviewed-by: Christine Caulfield <ccaulfie@redhat.com>
>---
> exec/main.c |    6 ++++--
> 1 files changed, 4 insertions(+), 2 deletions(-)
>
>diff --git a/exec/main.c b/exec/main.c
>index 17ebcf5..8cf551e 100644
>--- a/exec/main.c
>+++ b/exec/main.c
>@@ -196,6 +196,7 @@ static void corosync_blackbox_write_to_file (void)
> 	char time_str[PATH_MAX];
> 	struct tm cur_time_tm;
> 	time_t cur_time_t;
>+	ssize_t res;
> 
> 	cur_time_t = time(NULL);
> 	localtime_r(&cur_time_t, &cur_time_tm);
>@@ -206,8 +207,9 @@ static void corosync_blackbox_write_to_file (void)
> 	    time_str,
> 	    (long long int)getpid());
> 
>-	qb_log_blackbox_write_to_file(fname);
>-
>+	if ((res = qb_log_blackbox_write_to_file(fname)) < 0) {
>+		LOGSYS_PERROR(-res, LOGSYS_LEVEL_ERROR, "Can't store blackbox file");
>+	}
> 	unlink(LOCALSTATEDIR "/lib/corosync/fdata");
> 	if (symlink(fname, LOCALSTATEDIR "/lib/corosync/fdata") == -1) {
> 		log_printf(LOGSYS_LEVEL_ERROR, "Can't create symlink to '%s' for corosync blackbox file '%s'",
>-- 
>1.7.1
>

Actions: View | Diff

Attachments on bug 1108525: 908000 | 908001 | 908002 | 908003