Attachment 908125 Details for Bug 1097436 – New patch 2/2

[patch] New patch 2/2

0002-asus-wmi-backlight_init-Stop-treating-ENODEV-as-if-i.patch (text/plain), 1.46 KB, created by Hans de Goede on 2014-06-12 13:17:03 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Hans de Goede

Created: 2014-06-12 13:17:03 UTC

Size: 1.46 KB

patch

obsolete

>From c01f8ff03ad7547ed5996f209742e8cd2abd6d61 Mon Sep 17 00:00:00 2001
>From: Hans de Goede <hdegoede@redhat.com>
>Date: Thu, 12 Jun 2014 14:34:43 +0200
>Subject: [PATCH 2/2] asus-wmi: backlight_init: Stop treating -ENODEV as if its
> not an error
>
>When bl_power support got added to asus-wmi, the error handling for it was
>written to ignore -ENODEV, to avoid not registering a backlight interface for
>models which have no bl_power control, but do have brightness control.
>
>At the same time the error handling for brightness_max was modified to do the
>same, this is wrong, when there is no brightness_max asus-wmi should not
>register a backlight interface.
>
>Note the caller of asus_wmi_backlight_init already special cases -ENODEV,
>and will not cause the wmi driver regristration to fail because of a
>-ENODEV return from asus_wmi_backlight_init.
>
>https://bugzilla.redhat.com/show_bug.cgi?id=1097436
>
>Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>---
> drivers/platform/x86/asus-wmi.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
>diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c
>index 6628d8a..e0c42e4 100644
>--- a/drivers/platform/x86/asus-wmi.c
>+++ b/drivers/platform/x86/asus-wmi.c
>@@ -1274,10 +1274,7 @@ static int asus_wmi_backlight_init(struct asus_wmi *asus)
> 	int power;
> 
> 	max = read_brightness_max(asus);
>-
>-	if (max == -ENODEV)
>-		max = 0;
>-	else if (max < 0)
>+	if (max < 0)
> 		return max;
> 
> 	power = read_backlight_power(asus);
>-- 
>2.0.0
>

Actions: View | Diff

Attachments on bug 1097436: 908124 | 908125