Attachment 909914 Details for Bug 1100599 – Tomcat 7 patch

[patch] Tomcat 7 patch

tomcat7-ClearRefsLogAsInfo (text/plain), 7.93 KB, created by Rémy Maucherat on 2014-06-18 09:43:34 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Rémy Maucherat

Created: 2014-06-18 09:43:34 UTC

Size: 7.93 KB

patch

obsolete

>Index: java/org/apache/catalina/loader/WebappClassLoader.java
>===================================================================
>--- java/org/apache/catalina/loader/WebappClassLoader.java	(revision 1601826)
>+++ java/org/apache/catalina/loader/WebappClassLoader.java	(working copy)
>@@ -2087,7 +2087,7 @@
>             List<String> driverNames = (List<String>) obj.getClass().getMethod(
>                     "clearJdbcDriverRegistrations").invoke(obj);
>             for (String name : driverNames) {
>-                log.error(sm.getString("webappClassLoader.clearJdbc",
>+                log.info(sm.getString("webappClassLoader.clearJdbc",
>                         contextName, name));
>             }
>         } catch (Exception e) {
>@@ -2094,7 +2094,7 @@
>             // So many things to go wrong above...
>             Throwable t = ExceptionUtils.unwrapInvocationTargetException(e);
>             ExceptionUtils.handleThrowable(t);
>-            log.warn(sm.getString(
>+            log.info(sm.getString(
>                     "webappClassLoader.jdbcRemoveFailed", contextName), t);
>         } finally {
>             if (is != null) {
>@@ -2101,7 +2101,7 @@
>                 try {
>                     is.close();
>                 } catch (IOException ioe) {
>-                    log.warn(sm.getString(
>+                    log.info(sm.getString(
>                             "webappClassLoader.jdbcRemoveStreamError",
>                             contextName), ioe);
>                 }
>@@ -2284,10 +2284,10 @@
>                     }
> 
>                     if (isRequestThread(thread)) {
>-                        log.error(sm.getString("webappClassLoader.warnRequestThread",
>+                        log.info(sm.getString("webappClassLoader.warnRequestThread",
>                                 contextName, thread.getName()));
>                     } else {
>-                        log.error(sm.getString("webappClassLoader.warnThread",
>+                        log.info(sm.getString("webappClassLoader.warnThread",
>                                 contextName, thread.getName()));
>                     }
> 
>@@ -2336,19 +2336,19 @@
>                             }
>                         }
>                     } catch (SecurityException e) {
>-                        log.warn(sm.getString(
>+                        log.info(sm.getString(
>                                 "webappClassLoader.stopThreadFail",
>                                 thread.getName(), contextName), e);
>                     } catch (NoSuchFieldException e) {
>-                        log.warn(sm.getString(
>+                        log.info(sm.getString(
>                                 "webappClassLoader.stopThreadFail",
>                                 thread.getName(), contextName), e);
>                     } catch (IllegalArgumentException e) {
>-                        log.warn(sm.getString(
>+                        log.info(sm.getString(
>                                 "webappClassLoader.stopThreadFail",
>                                 thread.getName(), contextName), e);
>                     } catch (IllegalAccessException e) {
>-                        log.warn(sm.getString(
>+                        log.info(sm.getString(
>                                 "webappClassLoader.stopThreadFail",
>                                 thread.getName(), contextName), e);
>                     }
>@@ -2463,7 +2463,7 @@
>                 }
>             }
> 
>-            log.error(sm.getString("webappClassLoader.warnTimerThread",
>+            log.info(sm.getString("webappClassLoader.warnTimerThread",
>                     contextName, thread.getName()));
> 
>         } catch (Exception e) {
>@@ -2470,7 +2470,7 @@
>             // So many things to go wrong above...
>             Throwable t = ExceptionUtils.unwrapInvocationTargetException(e);
>             ExceptionUtils.handleThrowable(t);
>-            log.warn(sm.getString(
>+            log.info(sm.getString(
>                     "webappClassLoader.stopTimerThreadFail",
>                     thread.getName(), contextName), t);
>         }
>@@ -2517,7 +2517,7 @@
>             }
>         } catch (Throwable t) {
>             ExceptionUtils.handleThrowable(t);
>-            log.warn(sm.getString(
>+            log.info(sm.getString(
>                     "webappClassLoader.checkThreadLocalsForLeaksFail",
>                     getContextName()), t);
>         }
>@@ -2560,7 +2560,7 @@
>                                 try {
>                                     args[2] = key.toString();
>                                 } catch (Exception e) {
>-                                    log.error(sm.getString(
>+                                    log.info(sm.getString(
>                                             "webappClassLoader.checkThreadLocalsForLeaks.badKey",
>                                             args[1]), e);
>                                     args[2] = sm.getString(
>@@ -2572,7 +2572,7 @@
>                                 try {
>                                     args[4] = value.toString();
>                                 } catch (Exception e) {
>-                                    log.error(sm.getString(
>+                                    log.info(sm.getString(
>                                             "webappClassLoader.checkThreadLocalsForLeaks.badValue",
>                                             args[3]), e);
>                                     args[4] = sm.getString(
>@@ -2586,7 +2586,7 @@
>                                             args));
>                                 }
>                             } else {
>-                                log.error(sm.getString(
>+                                log.info(sm.getString(
>                                         "webappClassLoader.checkThreadLocalsForLeaks",
>                                         args));
>                             }
>@@ -2742,16 +2742,16 @@
>             log.info(sm.getString("webappClassLoader.clearRmiInfo",
>                     contextName), e);
>         } catch (SecurityException e) {
>-            log.warn(sm.getString("webappClassLoader.clearRmiFail",
>+            log.info(sm.getString("webappClassLoader.clearRmiFail",
>                     contextName), e);
>         } catch (NoSuchFieldException e) {
>-            log.warn(sm.getString("webappClassLoader.clearRmiFail",
>+            log.info(sm.getString("webappClassLoader.clearRmiFail",
>                     contextName), e);
>         } catch (IllegalArgumentException e) {
>-            log.warn(sm.getString("webappClassLoader.clearRmiFail",
>+            log.info(sm.getString("webappClassLoader.clearRmiFail",
>                     contextName), e);
>         } catch (IllegalAccessException e) {
>-            log.warn(sm.getString("webappClassLoader.clearRmiFail",
>+            log.info(sm.getString("webappClassLoader.clearRmiFail",
>                     contextName), e);
>         }
>     }
>@@ -2820,12 +2820,12 @@
>                         Integer.valueOf(countRemoved), contextName));
>             }
>         } catch (SecurityException e) {
>-            log.error(sm.getString(
>+            log.info(sm.getString(
>                     "webappClassLoader.clearReferencesResourceBundlesFail",
>                     contextName), e);
>         } catch (NoSuchFieldException e) {
>             if (Globals.IS_ORACLE_JVM) {
>-                log.error(sm.getString(
>+                log.info(sm.getString(
>                         "webappClassLoader.clearReferencesResourceBundlesFail",
>                         getContextName()), e);
>             } else {
>@@ -2834,11 +2834,11 @@
>                         getContextName()), e);
>             }
>         } catch (IllegalArgumentException e) {
>-            log.error(sm.getString(
>+            log.info(sm.getString(
>                     "webappClassLoader.clearReferencesResourceBundlesFail",
>                     contextName), e);
>         } catch (IllegalAccessException e) {
>-            log.error(sm.getString(
>+            log.info(sm.getString(
>                     "webappClassLoader.clearReferencesResourceBundlesFail",
>                     contextName), e);
>         }
>

Actions: View | Diff

Attachments on bug 1100599: 898574 | 909914 | 909915