Attachment 911803 Details for Bug 977869 – Move duration calculation in AsyncIO.cpp

[patch] Move duration calculation in AsyncIO.cpp

2a.diff (text/plain), 1.54 KB, created by Ernie on 2014-06-24 16:02:18 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Ernie

Created: 2014-06-24 16:02:18 UTC

Size: 1.54 KB

patch

obsolete

>diff --git a/qpid/cpp/src/qpid/sys/posix/AsynchIO.cpp b/qpid/cpp/src/qpid/sys/posix/AsynchIO.cpp
>index 353a55f..5d607a8 100644
>--- a/qpid/cpp/src/qpid/sys/posix/AsynchIO.cpp
>+++ b/qpid/cpp/src/qpid/sys/posix/AsynchIO.cpp
>@@ -443,7 +443,6 @@ void AsynchIO::readable(DispatchHandle& h) {
>             errno = 0;
>             int readCount = buff->byteCount-buff->dataCount;
>             int rc = socket.read(buff->bytes + buff->dataCount, readCount);
>-            int64_t duration = Duration(readStartTime, AbsTime::now());
>             ++readCalls;
>             if (rc > 0) {
>                 buff->dataCount += rc;
>@@ -451,6 +450,7 @@ void AsynchIO::readable(DispatchHandle& h) {
>                 total += rc;
> 
>                 readCallback(*this, buff);
>+                int64_t duration = Duration(readStartTime, AbsTime::now());
>                 if (rc != readCount) {
>                     // If we didn't fill the read buffer then time to stop reading
>                     QPID_PROBE4(asynchio_read_finished_done, &h, duration, total, readCalls);
>@@ -468,7 +468,7 @@ void AsynchIO::readable(DispatchHandle& h) {
>                 bufferQueue.push_front(buff);
>                 assert(buff);
> 
>-                QPID_PROBE5(asynchio_read_finished_error, &h, duration, total, readCalls, errno);
>+                QPID_PROBE5(asynchio_read_finished_error, &h, Duration(readStartTime, AbsTime::now()), total, readCalls, errno);
>                 // Eof or other side has gone away
>                 if (rc == 0 || errno == ECONNRESET) {
>                     eofCallback(*this);

Actions: View | Diff

Attachments on bug 977869: 765096 | 765097 | 911803