Attachment 912417 Details for Bug 693721 – Adds "fullName" field and trucates existing "name" field in needed

[patch] Adds "fullName" field and trucates existing "name" field in needed

bz693721.patch (text/plain), 2.72 KB, created by Ernie on 2014-06-26 13:11:00 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Ernie

Created: 2014-06-26 13:11:00 UTC

Size: 2.72 KB

patch

obsolete

>diff --git a/qpid/cpp/src/qpid/broker/SessionState.cpp b/qpid/cpp/src/qpid/broker/SessionState.cpp
>index fca5b4f..f6c8f5c 100644
>--- a/qpid/cpp/src/qpid/broker/SessionState.cpp
>+++ b/qpid/cpp/src/qpid/broker/SessionState.cpp
>@@ -69,8 +69,11 @@ void SessionState::addManagementObject() {
>     if (parent != 0) {
>         ManagementAgent* agent = getBroker().getManagementAgent();
>         if (agent != 0) {
>-            mgmtObject = _qmf::Session::shared_ptr(new _qmf::Session
>-                (agent, this, parent, getId().getName()));
>+            std::string name(getId().getName());
>+            std::string fullName(name);
>+            if (name.length() >= std::numeric_limits<uint8_t>::max())
>+                name.resize(std::numeric_limits<uint8_t>::max()-1);
>+            mgmtObject = _qmf::Session::shared_ptr(new _qmf::Session                           (agent, this, parent, name, fullName));
>             mgmtObject->set_attached (0);
>             mgmtObject->set_detachedLifespan (0);
>             mgmtObject->clr_expireTime();
>diff --git a/qpid/cpp/src/qpid/broker/amqp/ManagedSession.cpp b/qpid/cpp/src/qpid/broker/amqp/ManagedSession.cpp
>index 5917ddb..84b5c78 100644
>--- a/qpid/cpp/src/qpid/broker/amqp/ManagedSession.cpp
>+++ b/qpid/cpp/src/qpid/broker/amqp/ManagedSession.cpp
>@@ -36,7 +36,11 @@ ManagedSession::ManagedSession(Broker& broker, ManagedConnection& p, const std::
> {
>     qpid::management::ManagementAgent* agent = broker.getManagementAgent();
>     if (agent != 0) {
>-        session = _qmf::Session::shared_ptr(new _qmf::Session(agent, this, broker.GetVhostObject(), id));
>+        std::string name(id);
>+        std::string fullName(name);
>+        if (name.length() >= std::numeric_limits<uint8_t>::max())
>+            name.resize(std::numeric_limits<uint8_t>::max()-1);
>+        session = _qmf::Session::shared_ptr(new _qmf::Session(agent, this, broker.GetVhostObject(), name, fullName));
>         session->set_attached(true);
>         session->set_detachedLifespan(0);
>         session->clr_expireTime();
>diff --git a/qpid/specs/management-schema.xml b/qpid/specs/management-schema.xml
>index a0feba2..6b1ded0 100644
>--- a/qpid/specs/management-schema.xml
>+++ b/qpid/specs/management-schema.xml
>@@ -510,6 +510,7 @@
>   <class name="Session">
>     <property name="vhostRef"         type="objId"   references="Vhost" access="RC" index="y" parentRef="y"/>
>     <property name="name"             type="sstr"    access="RC" index="y"/>
>+    <property name="fullName"         type="lstr"    access="RC" index="y"/>
>     <property name="channelId"        type="uint16"  access="RO"/>
>     <property name="connectionRef"    type="objId"   references="Connection" access="RO"/>
>     <property name="detachedLifespan" type="uint32"  access="RO" unit="second"/>

Actions: View | Diff

Attachments on bug 693721: 912417 | 917427 | 917432 | 918411