Login
[x]
Log in using an account from:
Fedora Account System
Red Hat Associate
Red Hat Customer
Or login using a Red Hat Bugzilla account
Forgot Password
Login:
Hide Forgot
Create an Account
Red Hat Bugzilla – Attachment 914594 Details for
Bug 1037091
gnomad2 FTBFS if "-Werror=format-security" flag is used
[?]
New
Simple Search
Advanced Search
My Links
Browse
Requests
Reports
Current State
Search
Tabular reports
Graphical reports
Duplicates
Other Reports
User Changes
Plotly Reports
Bug Status
Bug Severity
Non-Defaults
|
Product Dashboard
Help
Page Help!
Bug Writing Guidelines
What's new
Browser Support Policy
5.0.4.rh83 Release notes
FAQ
Guides index
User guide
Web Services
Contact
Legal
This site requires JavaScript to be enabled to function correctly, please enable it.
[patch]
Fix FTBFS with -Werror=format-security
Fix-FTBFS-with--Werrorformat-security-1037091-1106.patch (text/plain), 3.10 KB, created by
Yaakov Selkowitz
on 2014-07-03 22:40:50 UTC
(
hide
)
Description:
Fix FTBFS with -Werror=format-security
Filename:
MIME Type:
Creator:
Yaakov Selkowitz
Created:
2014-07-03 22:40:50 UTC
Size:
3.10 KB
patch
obsolete
>From dc280f17590e61bfe3d09f16b1f282371673a92f Mon Sep 17 00:00:00 2001 >From: Yaakov Selkowitz <yselkowitz@users.sourceforge.net> >Date: Thu, 3 Jul 2014 17:40:07 -0500 >Subject: [PATCH] Fix FTBFS with -Werror=format-security (#1037091, #1106666) > >--- > gnomad2-2.9.6-format-security.patch | 20 ++++++++++++++++++++ > gnomad2.spec | 14 +++++++------- > 2 files changed, 27 insertions(+), 7 deletions(-) > create mode 100644 gnomad2-2.9.6-format-security.patch > >diff --git a/gnomad2-2.9.6-format-security.patch b/gnomad2-2.9.6-format-security.patch >new file mode 100644 >index 0000000..bcb08c8 >--- /dev/null >+++ b/gnomad2-2.9.6-format-security.patch >@@ -0,0 +1,20 @@ >+--- a/src/util.c >++++ b/src/util.c >+@@ -210,7 +210,7 @@ void create_error_dialog(gchar *errorstring) >+ GTK_DIALOG_MODAL | GTK_DIALOG_DESTROY_WITH_PARENT, >+ GTK_MESSAGE_ERROR, >+ GTK_BUTTONS_CLOSE, >+- errorstring); >++ "%s", errorstring); >+ g_signal_connect_object(GTK_OBJECT(dialog), >+ "delete_event", >+ G_CALLBACK(gtk_widget_destroy), >+@@ -234,7 +234,7 @@ gboolean request_confirmation_dialog(gchar *confirmstring) >+ GTK_DIALOG_MODAL | GTK_DIALOG_DESTROY_WITH_PARENT, >+ GTK_MESSAGE_QUESTION, >+ GTK_BUTTONS_YES_NO, >+- confirmstring); >++ "%s", confirmstring); >+ i = gtk_dialog_run(GTK_DIALOG(dialog)); >+ gtk_widget_destroy(dialog); >+ if (i == GTK_RESPONSE_YES) { >diff --git a/gnomad2.spec b/gnomad2.spec >index e37133c..29e28c1 100644 >--- a/gnomad2.spec >+++ b/gnomad2.spec >@@ -2,7 +2,7 @@ > > Name: gnomad2 > Version: 2.9.6 >-Release: 8%{?dist} >+Release: 9%{?dist} > > Summary: A GNOME 2.0 client for the Creative Jukeboxes and Dell DJs > License: GPLv2+ >@@ -10,7 +10,7 @@ URL: http://gnomad2.sourceforge.net > > Group: Applications/Multimedia > Source: http://download.sourceforge.net/%{name}/%{name}-%{version}.tar.gz >-BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) >+Patch0: gnomad2-2.9.6-format-security.patch > > Requires(post): desktop-file-utils > Requires(postun): desktop-file-utils >@@ -36,13 +36,13 @@ Creative EAX sound processor on older jukebox devices. > > %prep > %setup >+%patch0 -p1 > > %build > %configure > make %{?_smp_mflags} > > %install >-rm -rf $RPM_BUILD_ROOT > %makeinstall > # Rename this so it matches the distribution > desktop-file-install --delete-original \ >@@ -52,9 +52,6 @@ desktop-file-install --delete-original \ > # Generate a list of all available translations > %find_lang %{name} > >-%clean >-rm -rf $RPM_BUILD_ROOT >- > %post > update-desktop-database -q > >@@ -62,7 +59,6 @@ update-desktop-database -q > update-desktop-database -q > > %files -f %{name}.lang >-%defattr(-,root,root) > %{_bindir}/* > %{_mandir}/man1/* > %{_datadir}/applications/* >@@ -71,6 +67,10 @@ update-desktop-database -q > %doc AUTHORS NEWS README COPYING ChangeLog > > %changelog >+* Thu Jul 03 2014 Yaakov Selkowitz <yselkowi@redhat.com> - 2.9.6-9 >+- Fix FTBFS with -Werror=format-security (#1037091, #1106666) >+- Cleanup spec >+ > * Sat Jun 07 2014 Fedora Release Engineering <rel-eng@lists.fedoraproject.org> - 2.9.6-8 > - Rebuilt for https://fedoraproject.org/wiki/Fedora_21_Mass_Rebuild > >-- >1.9.3
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
Attachments on
bug 1037091
: 914594